Fix SSE

[TienHuyIoT]

• Avoid self-deadlock by using recursive mutex.
• Add test case for example ServerSentEvents.

[Copilot]

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/AsyncEventSource.cpp:405

• Typographical error: 'insteads' should be corrected to 'instead'.

 * @brief: Fix self-deadlock by using recursive_mutex insteads of mutex.

[mathieucarbou]

@TienHuyIoT did you look also at the websocket code that is similar ? Maybe the same issue is there ?

[TienHuyIoT]

@TienHuyIoT did you look also at the websocket code that is similar ? Maybe the same issue is there ?

Yes, they are almost the same.

[mathieucarbou]

@TienHuyIoT did you look also at the websocket code that is similar ? Maybe the same issue is there ?

Yes, they are almost the same.

Do you mind adding a commit for websocket also ?

[TienHuyIoT]

@TienHuyIoT did you look also at the websocket code that is similar ? Maybe the same issue is there ?

Yes, they are almost the same.

Do you mind adding a commit for websocket also ?

Could you please explain your concern in more detail? I'm willing to help, but I don't fully understand your request.

[mathieucarbou]

@TienHuyIoT did you look also at the websocket code that is similar ? Maybe the same issue is there ?

Yes, they are almost the same.

Do you mind adding a commit for websocket also ?

Could you please explain your concern in more detail? I'm willing to help, but I don't fully understand your request.

I was asking if the same kind of deadlock could occur in the n websocket code with the use of normal mutexes in in websocket code, and if yes, if you could take the opportunity to also fix the websocket code. But that's just a question - not something you need to do if you do not want to

[TienHuyIoT]

@TienHuyIoT did you look also at the websocket code that is similar ? Maybe the same issue is there ?

Yes, they are almost the same.

Do you mind adding a commit for websocket also ?

Could you please explain your concern in more detail? I'm willing to help, but I don't fully understand your request.

I was asking if the same kind of deadlock could occur in the n websocket code with the use of normal mutexes in in websocket code, and if yes, if you could take the opportunity to also fix the websocket code. But that's just a question - not something you need to do if you do not want to

Thanks for your explanation!
I’ve understood your point. The previous pull request that addressed the WebSocket issue has already resolved the deadlock in the WebSocket client handler by using a standard mutex.
If that was your concern, no further action is needed, as it's already implemented.
However, if I have other findings, I will commit them late.
Please let me know if you have any questions.

[mathieucarbou]

@TienHuyIoT : thanks a lot!

[mathieucarbou]

I took the liberty to update this PR and rebase it on top of main and fix the websocket commits that were still there due to a missing rebase

[mathieucarbou]

@me-no-dev @vortigont : this PR is good to go for me. Can you please have a look ?