-
Notifications
You must be signed in to change notification settings - Fork 28
AsyncTCP without Arduino (ESP-IDF only) #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gnalbandian : FYI the new PR that I will complement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (2)
- CMakeLists.txt: Language not supported
- idf_component_examples/client/CMakeLists.txt: Language not supported
306ef2e
to
392e870
Compare
Hi @everyone! @mathieucarbou I've made a quick read over the code changes and it seems pretty good to me. |
Everything good! Works without issues in my app. The only thing I noticed while testing some examples is that the client _pcb->local_port gets zeroed before the client disconnect callback gets called. Maybe it's fine. I've seen this behavior in the main branch also. I (5856) AsyncTCP: ** data received by client: 62214: len=202 This is the code:
|
Thanks for reporting that, I will create an issue from that and talk with the team. |
dacb0ba
to
8c8766a
Compare
- Added preprocessor macros to detect and separate ESP-IDF vs Arduino
8c8766a
to
5acacfc
Compare
This PR complements the work from @gnalbandian in PR #47