Update SettingsHelper to not throw exception if the settings file can not be read #3935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornhellander
force-pushed
the
feature/incorrect-settings-path
branch
from
2087dd0 to
51ae969
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3935 +/- ##
==========================================
- Coverage 97.44% 97.44% -0.01%
==========================================
Files 926 931 +5
Lines 110283 110329 +46
Branches 3319 3320 +1
==========================================
+ Hits 107467 107508 +41
- Misses 1847 1851 +4
- Partials 969 970 +1 🚀 New features to boost your workflow:
|
bjornhellander
force-pushed
the
feature/incorrect-settings-path
branch
from
51ae969 to
c4d2fe4
Compare
bjornhellander
force-pushed
the
feature/incorrect-settings-path
branch
from
c4d2fe4 to
4c7a065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3902
I don't see a way to write unit tests for this, but I have used the generated nuget and verified that AD0001 is no longer triggered, and that SA0002 is triggered instead.
CS2001 is also triggered, so maybe the SA0002 was unnecessary. It would have been easy to instead treat it as if no settings file was found.