Skip to content

Conversation

typed-sigterm
Copy link
Contributor

What is this PR about?

We keep getting errors like:

Initializing deployment
Build static
Pulling registry.dev.paperchemis.com/paper_chemis/backend:latest: ✅
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
Login Succeeded
latest: Pulling from paper_chemis/backend
Digest: sha256:2120ec5911d210f2addc380e1f1e2838cee59ace83750ad0918bc3da2069f9ea
Status: Image is up to date for registry.dev.paperchemis.com/paper_chemis/backend:latest
registry.dev.paperchemis.com/paper_chemis/backend:latest
❌ Error

No one knows what the problem is...

Checklist

Before submitting this PR, please make sure that:

@@ -42,7 +42,7 @@ export const buildDocker = async (
await mechanizeDockerContainer(application);
writeStream.write("\nDocker Deployed: ✅\n");
} catch (error) {
writeStream.write("❌ Error");
writeStream.write("❌ ${error}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this we should do something like, because error can be an object

Suggested change
writeStream.write("❌ ${error}");
writeStream.write("❌ ${error instanceof Error ? error.message : "Unknown error"}");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But `${new Error('message')}` is evaluated to Error: message without losing information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, that code does nothing; it will only print ${error} as a string.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮😅

@@ -42,7 +42,7 @@ export const buildDocker = async (
await mechanizeDockerContainer(application);
writeStream.write("\nDocker Deployed: ✅\n");
} catch (error) {
writeStream.write("❌ Error");
writeStream.write("❌ ${error}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, that code does nothing; it will only print ${error} as a string.

@Siumauricio Siumauricio merged commit 0dca1b2 into Dokploy:canary Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants