-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat:wildcard domains for prod apps #2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation is missing on the docker compose which are handled by labels
you can see the packages/server/src/utils/docker/domain.ts file, Line 310 For reference
@@ -0,0 +1 @@ | |||
ALTER TABLE "domain" ADD COLUMN "isWildcard" boolean DEFAULT false NOT NULL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you drop the migrations and generate again the migrations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Can you add docs for this wildcard domains? https://github.com/Dokploy/website ? |
just made a pull requist to the docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the CI/CD linter?
And add a few cases in the test in these files?
- Compose domains (apps/dokploy/test/compose/domain/labels.test.ts)
- Applications (apps/dokploy/test/traefik/traefik.test.ts)
to cover this cases when the isWildcard is enabled?
- Added comprehensive test coverage for isWildcard functionality - Tests cover basic wildcard patterns, complex patterns, HTTPS redirects, certificates, and middleware combinations - Ensures wildcard domains generate proper HostRegexp rules instead of Host rules
Can you check the tests? |
@swalha1999 this is still on progress? |
this is like Subdomains for tenants like in Vercel multi tenant and Wildcard Domains