Skip to content

Conversation

sethsamuel
Copy link
Contributor

What does this PR do?

  • Migrates Postgres config to the InstanceConfg model
  • Adds and extends config validation
  • Emits an agent health event when a config is loaded

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 90.97104% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.25%. Comparing base (f72a071) to head (263d8d5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

example: true
- name: locks_idle_in_transaction
description: Configure collection of idle in transaction lock age metrics
hidden: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hidden?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to match current spec. For some reason all the properties were hidden but not the top level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants