Skip to content

Conversation

thedavl
Copy link
Contributor

@thedavl thedavl commented Jul 19, 2023

What does this PR do?

fix flaky serverless mini agent integration test

It seems like the previous way we were invoking the integration test gcloud function (using a known url prefix and just appending the function name) did not reliably invoke the function. It would sometimes return 404s.

This PR changes the test to capture the output from the function deploy command, extract the function url from the output, and invoke the function using it.

Motivation

Plugin Checklist

Additional Notes

@github-actions
Copy link

github-actions bot commented Jul 19, 2023

Overall package size

Self size: 4.91 MB
Deduped: 58.01 MB
No deduping: 58.1 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.1.0 10.66 MB 11.5 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #3418 (eb8a4c8) into master (212c440) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3418   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files         218      218           
  Lines        8572     8572           
  Branches       33       33           
=======================================
  Hits         7239     7239           
  Misses       1333     1333           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thedavl thedavl changed the title try to fix flaky test Fix flaky serverless integration test Jul 19, 2023
@pr-commenter
Copy link

pr-commenter bot commented Jul 19, 2023

Benchmarks

Benchmark execution time: 2023-07-20 14:07:18

Comparing candidate commit eb8a4c8 in PR branch david.lee/fix-sls-integration-test with baseline commit 212c440 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 473 metrics, 19 unstable metrics.

@thedavl thedavl marked this pull request as ready for review July 19, 2023 18:30
@thedavl thedavl requested a review from a team as a code owner July 19, 2023 18:30
@astuyve astuyve merged commit 660fefa into master Jul 20, 2023
szegedi pushed a commit that referenced this pull request Jul 21, 2023
* try to fix flaky test

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh
szegedi pushed a commit that referenced this pull request Jul 21, 2023
* try to fix flaky test

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh
szegedi pushed a commit that referenced this pull request Jul 21, 2023
* try to fix flaky test

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh
This was referenced Jul 21, 2023
szegedi pushed a commit that referenced this pull request Jul 21, 2023
* try to fix flaky test

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh
szegedi pushed a commit that referenced this pull request Jul 21, 2023
* try to fix flaky test

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh
szegedi pushed a commit that referenced this pull request Jul 21, 2023
* try to fix flaky test

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh
szegedi pushed a commit that referenced this pull request Jul 21, 2023
* try to fix flaky test

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh
tlhunter pushed a commit that referenced this pull request Jul 21, 2023
* try to fix flaky test

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh
tlhunter pushed a commit that referenced this pull request Jul 21, 2023
* try to fix flaky test

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh
tlhunter pushed a commit that referenced this pull request Jul 21, 2023
* try to fix flaky test

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh

* Update test-gcloud-function.sh
@thedavl thedavl deleted the david.lee/fix-sls-integration-test branch July 21, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants