fix: Handle case where Lambda handler is using callbacks instead of p…

[astuyve]

…romises

What does this PR do?

Fixes DataDog/datadog-lambda-js#404

Motivation

I mistakenly believed that callbacks were deprecated along with the node12 runtime but I was sorely mistaken.

Plugin Checklist

• Unit tests.
• TypeScript definitions.
• TypeScript tests.
• API documentation.
• CircleCI jobs/workflows.
• Plugin is exported.

Additional Notes

[github-actions]

Overall package size

Self size: 4.9 MB
Deduped: 58 MB
No deduping: 58.09 MB

Dependency sizes

name	version	self size	total size
@datadog/native-iast-taint-tracking	1.5.0	14.86 MB	14.86 MB
@datadog/native-appsec	3.2.0	13.38 MB	13.39 MB
@datadog/pprof	3.1.0	10.66 MB	11.5 MB
protobufjs	7.2.4	2.74 MB	6.52 MB
@datadog/native-iast-rewriter	2.0.1	2.09 MB	2.1 MB
@opentelemetry/core	1.14.0	872.87 kB	1.47 MB
@datadog/native-metrics	2.0.0	898.77 kB	1.3 MB
@opentelemetry/api	1.4.1	780.32 kB	780.32 kB
msgpack-lite	0.1.26	201.16 kB	281.59 kB
opentracing	0.14.7	194.81 kB	194.81 kB
semver	7.5.3	93.39 kB	123.79 kB
@datadog/sketches-js	2.1.0	109.9 kB	109.9 kB
lodash.sortby	4.7.0	75.76 kB	75.76 kB
lru-cache	7.14.0	74.95 kB	74.95 kB
ipaddr.js	2.0.1	59.52 kB	59.52 kB
int64-buffer	0.1.10	49.18 kB	49.18 kB
ignore	5.2.0	48.87 kB	48.87 kB
import-in-the-middle	1.3.5	34.34 kB	38.81 kB
istanbul-lib-coverage	3.2.0	29.34 kB	29.34 kB
retry	0.10.1	27.44 kB	27.44 kB
lodash.uniq	4.5.0	25.01 kB	25.01 kB
limiter	1.1.5	23.17 kB	23.17 kB
lodash.kebabcase	4.1.1	17.75 kB	17.75 kB
lodash.pick	4.4.0	16.33 kB	16.33 kB
node-abort-controller	3.0.1	14.33 kB	14.33 kB
crypto-randomuuid	1.0.0	11.18 kB	11.18 kB
diagnostics_channel	1.1.0	7.07 kB	7.07 kB
path-to-regexp	0.1.7	6.78 kB	6.78 kB
koalas	1.0.2	6.47 kB	6.47 kB
methods	1.1.2	5.29 kB	5.29 kB
module-details-from-path	1.0.3	4.47 kB	4.47 kB

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

[codecov]

Codecov Report

Merging #3404 (765d972) into master (66f1fd3) will decrease coverage by 0.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3404      +/-   ##
==========================================
- Coverage   84.25%   83.65%   -0.61%     
==========================================
  Files         214       88     -126     
  Lines        8392     3145    -5247     
  Branches       33       33              
==========================================
- Hits         7071     2631    -4440     
+ Misses       1321      514     -807     

see 127 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[pr-commenter]

Benchmarks

Benchmark execution time: 2023-07-18 14:24:41

Comparing candidate commit 765d972 in PR branch aj/fix-lambda-no-promise with baseline commit 66f1fd3 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 470 metrics, 19 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

• 🟥 max_rss_usage [+129.967KB; +145.545KB] or [+15.756%; +17.645%]

scenario:plugin-graphql-with-depth-off-18

• 🟥 max_rss_usage [+130.040KB; +147.148KB] or [+15.864%; +17.951%]

scenario:plugin-graphql-with-depth-on-max-18

• 🟥 max_rss_usage [+134.636KB; +151.664KB] or [+16.395%; +18.469%]

[duncanista]

LGTM – I totally forgot to add this, thought the promisifying in datadog-lambda-js would cover it!

Thanks AJ!