-
Notifications
You must be signed in to change notification settings - Fork 345
Fix same dependency detection #3386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix same dependency detection #3386
Conversation
Overall package sizeSelf size: 4.9 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3386 +/- ##
==========================================
+ Coverage 84.25% 84.27% +0.01%
==========================================
Files 214 214
Lines 8392 8398 +6
Branches 33 33
==========================================
+ Hits 7071 7077 +6
Misses 1321 1321
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4e50fc9
to
0732cf5
Compare
BenchmarksBenchmark execution time: 2023-07-18 09:28:53 Comparing candidate commit 06ae052 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 468 metrics, 21 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-18
|
d9f0356
to
06ae052
Compare
* Fix same dependency detection * Do not send same dependency:version twice * Clear map on stop * Update savedDependencies to savedDependenciesToSend to improve understanding
* Fix same dependency detection * Do not send same dependency:version twice * Clear map on stop * Update savedDependencies to savedDependenciesToSend to improve understanding
* Fix same dependency detection * Do not send same dependency:version twice * Clear map on stop * Update savedDependencies to savedDependenciesToSend to improve understanding
* Fix same dependency detection * Do not send same dependency:version twice * Clear map on stop * Update savedDependencies to savedDependenciesToSend to improve understanding
* Fix same dependency detection * Do not send same dependency:version twice * Clear map on stop * Update savedDependencies to savedDependenciesToSend to improve understanding
* Fix same dependency detection * Do not send same dependency:version twice * Clear map on stop * Update savedDependencies to savedDependenciesToSend to improve understanding
What does this PR do?
If the same library name is loaded from different
node_modules
directories, this library could be reported twice if they have different version number.Motivation
We might not be sending some expected dependencies.
Plugin Checklist
Additional Notes