Skip to content

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Jul 12, 2023

What does this PR do?

If the same library name is loaded from different node_modules directories, this library could be reported twice if they have different version number.

Motivation

We might not be sending some expected dependencies.

Plugin Checklist

  • Unit tests.

Additional Notes

@github-actions
Copy link

github-actions bot commented Jul 12, 2023

Overall package size

Self size: 4.9 MB
Deduped: 58 MB
No deduping: 58.09 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.1.0 10.66 MB 11.5 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #3386 (06ae052) into master (0b19639) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3386      +/-   ##
==========================================
+ Coverage   84.25%   84.27%   +0.01%     
==========================================
  Files         214      214              
  Lines        8392     8398       +6     
  Branches       33       33              
==========================================
+ Hits         7071     7077       +6     
  Misses       1321     1321              
Impacted Files Coverage Δ
packages/dd-trace/src/telemetry/dependencies.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uurien uurien force-pushed the ugaitz/fix-multiple-dependeny-different-version branch from 4e50fc9 to 0732cf5 Compare July 12, 2023 15:13
@pr-commenter
Copy link

pr-commenter bot commented Jul 12, 2023

Benchmarks

Benchmark execution time: 2023-07-18 09:28:53

Comparing candidate commit 06ae052 in PR branch ugaitz/fix-multiple-dependeny-different-version with baseline commit 0b19639 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 468 metrics, 21 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟥 max_rss_usage [+127.177KB; +141.287KB] or [+15.402%; +17.111%]

scenario:plugin-graphql-with-depth-off-18

  • 🟥 max_rss_usage [+116.236KB; +163.460KB] or [+14.160%; +19.913%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟥 max_rss_usage [+100.081KB; +171.019KB] or [+12.094%; +20.666%]

@uurien uurien marked this pull request as ready for review July 12, 2023 16:18
@uurien uurien requested a review from a team as a code owner July 12, 2023 16:18
CarlesDD
CarlesDD previously approved these changes Jul 13, 2023
@uurien uurien force-pushed the ugaitz/fix-multiple-dependeny-different-version branch from d9f0356 to 06ae052 Compare July 18, 2023 09:17
@uurien uurien merged commit f03c8a1 into master Jul 18, 2023
@uurien uurien deleted the ugaitz/fix-multiple-dependeny-different-version branch July 18, 2023 12:20
szegedi pushed a commit that referenced this pull request Jul 20, 2023
* Fix same dependency detection

* Do not send same dependency:version twice

* Clear map on stop

* Update savedDependencies to savedDependenciesToSend to improve understanding
@szegedi szegedi mentioned this pull request Jul 20, 2023
szegedi pushed a commit that referenced this pull request Jul 20, 2023
* Fix same dependency detection

* Do not send same dependency:version twice

* Clear map on stop

* Update savedDependencies to savedDependenciesToSend to improve understanding
@szegedi szegedi mentioned this pull request Jul 20, 2023
szegedi pushed a commit that referenced this pull request Jul 20, 2023
* Fix same dependency detection

* Do not send same dependency:version twice

* Clear map on stop

* Update savedDependencies to savedDependenciesToSend to improve understanding
This was referenced Jul 20, 2023
tlhunter pushed a commit that referenced this pull request Jul 21, 2023
* Fix same dependency detection

* Do not send same dependency:version twice

* Clear map on stop

* Update savedDependencies to savedDependenciesToSend to improve understanding
tlhunter pushed a commit that referenced this pull request Jul 21, 2023
* Fix same dependency detection

* Do not send same dependency:version twice

* Clear map on stop

* Update savedDependencies to savedDependenciesToSend to improve understanding
tlhunter pushed a commit that referenced this pull request Jul 21, 2023
* Fix same dependency detection

* Do not send same dependency:version twice

* Clear map on stop

* Update savedDependencies to savedDependenciesToSend to improve understanding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants