-
Notifications
You must be signed in to change notification settings - Fork 346
Taint request URI #3302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taint request URI #3302
Conversation
Overall package sizeSelf size: 4.88 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3302 +/- ##
==========================================
+ Coverage 84.09% 88.10% +4.01%
==========================================
Files 204 207 +3
Lines 8017 7855 -162
Branches 33 33
==========================================
+ Hits 6742 6921 +179
+ Misses 1275 934 -341
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
65ebab9
to
df272aa
Compare
BenchmarksBenchmark execution time: 2023-07-13 09:41:31 Comparing candidate commit 77c7ec9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 463 metrics, 29 unstable metrics. |
df272aa
to
4be651c
Compare
unvalidated redirect analyzer file has a TODO related with this PR. dd-trace-js/packages/dd-trace/src/appsec/iast/analyzers/unvalidated-redirect-analyzer.js Line 19 in 27e1530
|
b02ff9f
to
307d696
Compare
307d696
to
983992b
Compare
packages/dd-trace/test/appsec/iast/analyzers/unvalidated-redirect-analyzer.spec.js
Outdated
Show resolved
Hide resolved
983992b
to
6886e18
Compare
6886e18
to
04e4335
Compare
04e4335
to
c33f2e8
Compare
packages/dd-trace/test/appsec/iast/analyzers/unvalidated-redirect-analyzer.spec.js
Outdated
Show resolved
Hide resolved
* Taint request URI * Add check for safe tainted origins on unvalidated redirect analyzer * Change assertion construction for unvalidated redirect analyzer test * Add metric for uri sourcing * Fix PR comments
* Taint request URI * Add check for safe tainted origins on unvalidated redirect analyzer * Change assertion construction for unvalidated redirect analyzer test * Add metric for uri sourcing * Fix PR comments
* Taint request URI * Add check for safe tainted origins on unvalidated redirect analyzer * Change assertion construction for unvalidated redirect analyzer test * Add metric for uri sourcing * Fix PR comments
* Taint request URI * Add check for safe tainted origins on unvalidated redirect analyzer * Change assertion construction for unvalidated redirect analyzer test * Add metric for uri sourcing * Fix PR comments
* Taint request URI * Add check for safe tainted origins on unvalidated redirect analyzer * Change assertion construction for unvalidated redirect analyzer test * Add metric for uri sourcing * Fix PR comments
* Taint request URI * Add check for safe tainted origins on unvalidated redirect analyzer * Change assertion construction for unvalidated redirect analyzer test * Add metric for uri sourcing * Fix PR comments
What does this PR do?
Provides a new function in taint tracking to taint all relevant information from request:
Once IAST receives a message from a new request start, these information is tainted.
This PR also adds a check in
Unvalidated redirect analyzer
in order to not report vulnerability when tainted origins are URL or path parameters.Motivation
Taint more sources to improve custom code vulnerability detection.
Avoid false positives for Unvalidated redirect vulnerability.