Skip to content

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Jun 22, 2023

What does this PR do?

This applies the service naming schema logic (see #2941) to graphql.

Motivation

Consistent span names across tracers.

Plugin Checklist

Additional Notes

@rarguelloF rarguelloF changed the title implement naming schema for graphql plugin WIP: implement naming schema for graphql plugin Jun 22, 2023
@github-actions
Copy link

github-actions bot commented Jun 22, 2023

Overall package size

Self size: 4.9 MB
Deduped: 58 MB
No deduping: 58.09 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.1.0 10.66 MB 11.5 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #3279 (e291abc) into master (3cd0704) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #3279      +/-   ##
==========================================
- Coverage   84.27%   84.26%   -0.01%     
==========================================
  Files         214      216       +2     
  Lines        8398     8408      +10     
  Branches       33       33              
==========================================
+ Hits         7077     7085       +8     
- Misses       1321     1323       +2     
Impacted Files Coverage Δ
.../dd-trace/src/service-naming/schemas/v0/graphql.js 75.00% <75.00%> (ø)
.../dd-trace/src/service-naming/schemas/v1/graphql.js 75.00% <75.00%> (ø)
...es/dd-trace/src/service-naming/schemas/v0/index.js 100.00% <100.00%> (ø)
...es/dd-trace/src/service-naming/schemas/v1/index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rarguelloF rarguelloF force-pushed the rarguelloF/naming-schema-graphql branch from d4cd98d to ead5a13 Compare June 22, 2023 11:25
@pr-commenter
Copy link

pr-commenter bot commented Jun 22, 2023

Benchmarks

Benchmark execution time: 2023-07-18 09:29:51

Comparing candidate commit b64c101 in PR branch rarguelloF/naming-schema-graphql with baseline commit 66f1fd3 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 470 metrics, 19 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟥 max_rss_usage [+125.508KB; +150.960KB] or [+15.248%; +18.340%]

scenario:plugin-graphql-with-depth-off-18

  • 🟥 max_rss_usage [+133.654KB; +145.262KB] or [+16.311%; +17.727%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟥 max_rss_usage [+100.061KB; +172.607KB] or [+12.076%; +20.832%]

@rarguelloF rarguelloF changed the title WIP: implement naming schema for graphql plugin implement naming schema for graphql plugin Jun 22, 2023
Copy link
Contributor

@jbertran jbertran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of this.

@rarguelloF rarguelloF marked this pull request as ready for review June 23, 2023 14:53
@rarguelloF rarguelloF requested a review from a team as a code owner June 23, 2023 14:53
@rarguelloF rarguelloF requested a review from jbertran June 23, 2023 15:03
@tlhunter
Copy link
Member

Had to fix some merge conflicts

bengl
bengl previously approved these changes Jun 26, 2023
Copy link
Contributor

@jbertran jbertran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, sorry for not catching it sooner

jbertran
jbertran previously approved these changes Jun 27, 2023
Copy link
Contributor

@jbertran jbertran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rarguelloF rarguelloF requested a review from bengl June 28, 2023 13:49
tlhunter
tlhunter previously approved these changes Jun 29, 2023
@jbertran jbertran dismissed stale reviews from tlhunter and themself via 4cfa978 June 30, 2023 09:37
@jbertran jbertran force-pushed the rarguelloF/naming-schema-graphql branch from edc0ce3 to 4cfa978 Compare June 30, 2023 09:37
Qard
Qard previously approved these changes Jul 18, 2023
@jbertran jbertran merged commit 32c6646 into master Jul 20, 2023
szegedi pushed a commit that referenced this pull request Jul 20, 2023
* implement naming schema for graphql plugin
* implement schema v1 and add tests

---------

Co-authored-by: Thomas Hunter II <[email protected]>
Co-authored-by: Jordi Bertran de Balanda <[email protected]>
@szegedi szegedi mentioned this pull request Jul 20, 2023
szegedi pushed a commit that referenced this pull request Jul 20, 2023
* implement naming schema for graphql plugin
* implement schema v1 and add tests

---------

Co-authored-by: Thomas Hunter II <[email protected]>
Co-authored-by: Jordi Bertran de Balanda <[email protected]>
@szegedi szegedi mentioned this pull request Jul 20, 2023
szegedi pushed a commit that referenced this pull request Jul 20, 2023
* implement naming schema for graphql plugin
* implement schema v1 and add tests

---------

Co-authored-by: Thomas Hunter II <[email protected]>
Co-authored-by: Jordi Bertran de Balanda <[email protected]>
This was referenced Jul 20, 2023
tlhunter added a commit that referenced this pull request Jul 21, 2023
* implement naming schema for graphql plugin
* implement schema v1 and add tests

---------

Co-authored-by: Thomas Hunter II <[email protected]>
Co-authored-by: Jordi Bertran de Balanda <[email protected]>
tlhunter added a commit that referenced this pull request Jul 21, 2023
* implement naming schema for graphql plugin
* implement schema v1 and add tests

---------

Co-authored-by: Thomas Hunter II <[email protected]>
Co-authored-by: Jordi Bertran de Balanda <[email protected]>
tlhunter added a commit that referenced this pull request Jul 21, 2023
* implement naming schema for graphql plugin
* implement schema v1 and add tests

---------

Co-authored-by: Thomas Hunter II <[email protected]>
Co-authored-by: Jordi Bertran de Balanda <[email protected]>
@tlhunter tlhunter deleted the rarguelloF/naming-schema-graphql branch January 19, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants