-
Notifications
You must be signed in to change notification settings - Fork 346
implement naming schema for graphql plugin #3279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 4.9 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3279 +/- ##
==========================================
- Coverage 84.27% 84.26% -0.01%
==========================================
Files 214 216 +2
Lines 8398 8408 +10
Branches 33 33
==========================================
+ Hits 7077 7085 +8
- Misses 1321 1323 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d4cd98d
to
ead5a13
Compare
BenchmarksBenchmark execution time: 2023-07-18 09:29:51 Comparing candidate commit b64c101 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 470 metrics, 19 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for taking care of this.
Had to fix some merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing, sorry for not catching it sooner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Jordi Bertran de Balanda <[email protected]>
edc0ce3
to
4cfa978
Compare
* implement naming schema for graphql plugin * implement schema v1 and add tests --------- Co-authored-by: Thomas Hunter II <[email protected]> Co-authored-by: Jordi Bertran de Balanda <[email protected]>
* implement naming schema for graphql plugin * implement schema v1 and add tests --------- Co-authored-by: Thomas Hunter II <[email protected]> Co-authored-by: Jordi Bertran de Balanda <[email protected]>
* implement naming schema for graphql plugin * implement schema v1 and add tests --------- Co-authored-by: Thomas Hunter II <[email protected]> Co-authored-by: Jordi Bertran de Balanda <[email protected]>
* implement naming schema for graphql plugin * implement schema v1 and add tests --------- Co-authored-by: Thomas Hunter II <[email protected]> Co-authored-by: Jordi Bertran de Balanda <[email protected]>
* implement naming schema for graphql plugin * implement schema v1 and add tests --------- Co-authored-by: Thomas Hunter II <[email protected]> Co-authored-by: Jordi Bertran de Balanda <[email protected]>
* implement naming schema for graphql plugin * implement schema v1 and add tests --------- Co-authored-by: Thomas Hunter II <[email protected]> Co-authored-by: Jordi Bertran de Balanda <[email protected]>
What does this PR do?
This applies the service naming schema logic (see #2941) to
graphql
.Motivation
Consistent span names across tracers.
Plugin Checklist
Additional Notes