Allow https datadog agent url in continuous profiling (#3190) #3194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
approved these changes
May 30, 2023
rochdev
approved these changes
Jun 1, 2023
Codecov Report
@@ Coverage Diff @@
## master #3194 +/- ##
==========================================
+ Coverage 84.27% 84.28% +0.01%
==========================================
Files 214 214
Lines 8398 8400 +2
Branches 33 33
==========================================
+ Hits 7077 7080 +3
+ Misses 1321 1320 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nsavoire
approved these changes
Jun 14, 2023
szegedi
added a commit
that referenced
this pull request
Jul 20, 2023
Co-authored-by: Attila Szegedi <[email protected]>
szegedi
added a commit
that referenced
this pull request
Jul 20, 2023
Co-authored-by: Attila Szegedi <[email protected]>
szegedi
added a commit
that referenced
this pull request
Jul 20, 2023
Co-authored-by: Attila Szegedi <[email protected]>
tlhunter
pushed a commit
that referenced
this pull request
Jul 21, 2023
Co-authored-by: Attila Szegedi <[email protected]>
tlhunter
pushed a commit
that referenced
this pull request
Jul 21, 2023
Co-authored-by: Attila Szegedi <[email protected]>
tlhunter
pushed a commit
that referenced
this pull request
Jul 21, 2023
Co-authored-by: Attila Szegedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable to use continuous profiler with a https datadog agent.
Motivation
To fix #3190
Additional Notes
I've confirmed that profiling data is correctly sent to the agent with this fix.