-
Notifications
You must be signed in to change notification settings - Fork 312
Correct the mixup in compression algorithms on Oracle JDK 8 #9546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: 4039f5a | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~4039f5a53f, baseline=1.54.0-SNAPSHOT~3039978eaa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071718
Total [baseline] (8.715 s) : 0, 8715419
Agent [candidate] (1.072 s) : 0, 1071753
Total [candidate] (8.713 s) : 0, 8713315
section iast
Agent [baseline] (1.194 s) : 0, 1193572
Total [baseline] (9.328 s) : 0, 9327716
Agent [candidate] (1.19 s) : 0, 1189840
Total [candidate] (9.339 s) : 0, 9339399
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~4039f5a53f, baseline=1.54.0-SNAPSHOT~3039978eaa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (739.753 ms) : 0, 739753
BytebuddyAgent [candidate] (740.022 ms) : 0, 740022
GlobalTracer [baseline] (254.919 ms) : 0, 254919
GlobalTracer [candidate] (254.856 ms) : 0, 254856
AppSec [baseline] (30.884 ms) : 0, 30884
AppSec [candidate] (30.862 ms) : 0, 30862
Debugger [baseline] (6.456 ms) : 0, 6456
Debugger [candidate] (6.482 ms) : 0, 6482
Remote Config [baseline] (723.471 µs) : 0, 723
Remote Config [candidate] (694.266 µs) : 0, 694
Telemetry [baseline] (16.333 ms) : 0, 16333
Telemetry [candidate] (16.277 ms) : 0, 16277
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (854.266 ms) : 0, 854266
BytebuddyAgent [candidate] (851.209 ms) : 0, 851209
GlobalTracer [baseline] (246.231 ms) : 0, 246231
GlobalTracer [candidate] (246.663 ms) : 0, 246663
AppSec [baseline] (25.788 ms) : 0, 25788
AppSec [candidate] (28.093 ms) : 0, 28093
Debugger [baseline] (6.165 ms) : 0, 6165
Debugger [candidate] (6.049 ms) : 0, 6049
Remote Config [baseline] (609.604 µs) : 0, 610
Remote Config [candidate] (598.736 µs) : 0, 599
Telemetry [baseline] (8.353 ms) : 0, 8353
Telemetry [candidate] (8.248 ms) : 0, 8248
IAST [baseline] (29.737 ms) : 0, 29737
IAST [candidate] (26.581 ms) : 0, 26581
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~4039f5a53f, baseline=1.54.0-SNAPSHOT~3039978eaa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064406
Total [baseline] (10.716 s) : 0, 10715918
Agent [candidate] (1.065 s) : 0, 1064538
Total [candidate] (10.759 s) : 0, 10758875
section appsec
Agent [baseline] (1.247 s) : 0, 1247135
Total [baseline] (11.113 s) : 0, 11112911
Agent [candidate] (1.238 s) : 0, 1237617
Total [candidate] (11.11 s) : 0, 11109812
section iast
Agent [baseline] (1.192 s) : 0, 1192281
Total [baseline] (11.1 s) : 0, 11100453
Agent [candidate] (1.192 s) : 0, 1192255
Total [candidate] (11.141 s) : 0, 11140627
section profiling
Agent [baseline] (1.219 s) : 0, 1219345
Total [baseline] (11.0 s) : 0, 11000430
Agent [candidate] (1.211 s) : 0, 1210775
Total [candidate] (10.984 s) : 0, 10983617
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~4039f5a53f, baseline=1.54.0-SNAPSHOT~3039978eaa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (734.374 ms) : 0, 734374
BytebuddyAgent [candidate] (734.672 ms) : 0, 734672
GlobalTracer [baseline] (253.13 ms) : 0, 253130
GlobalTracer [candidate] (253.41 ms) : 0, 253410
AppSec [baseline] (30.72 ms) : 0, 30720
AppSec [candidate] (30.59 ms) : 0, 30590
Debugger [baseline] (6.389 ms) : 0, 6389
Debugger [candidate] (6.378 ms) : 0, 6378
Remote Config [baseline] (705.356 µs) : 0, 705
Remote Config [candidate] (687.59 µs) : 0, 688
Telemetry [baseline] (16.511 ms) : 0, 16511
Telemetry [candidate] (16.199 ms) : 0, 16199
section appsec
crashtracking [baseline] (1.487 ms) : 0, 1487
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (764.03 ms) : 0, 764030
BytebuddyAgent [candidate] (758.448 ms) : 0, 758448
GlobalTracer [baseline] (248.54 ms) : 0, 248540
GlobalTracer [candidate] (246.111 ms) : 0, 246111
AppSec [baseline] (172.333 ms) : 0, 172333
AppSec [candidate] (171.344 ms) : 0, 171344
Debugger [baseline] (6.057 ms) : 0, 6057
Debugger [candidate] (6.003 ms) : 0, 6003
Remote Config [baseline] (638.073 µs) : 0, 638
Remote Config [candidate] (626.935 µs) : 0, 627
Telemetry [baseline] (8.519 ms) : 0, 8519
Telemetry [candidate] (8.46 ms) : 0, 8460
IAST [baseline] (24.137 ms) : 0, 24137
IAST [candidate] (23.839 ms) : 0, 23839
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (853.32 ms) : 0, 853320
BytebuddyAgent [candidate] (853.648 ms) : 0, 853648
GlobalTracer [baseline] (244.593 ms) : 0, 244593
GlobalTracer [candidate] (245.256 ms) : 0, 245256
AppSec [baseline] (27.038 ms) : 0, 27038
AppSec [candidate] (26.187 ms) : 0, 26187
Debugger [baseline] (6.04 ms) : 0, 6040
Debugger [candidate] (6.09 ms) : 0, 6090
Remote Config [baseline] (603.109 µs) : 0, 603
Remote Config [candidate] (604.566 µs) : 0, 605
Telemetry [baseline] (8.297 ms) : 0, 8297
Telemetry [candidate] (8.223 ms) : 0, 8223
IAST [baseline] (29.846 ms) : 0, 29846
IAST [candidate] (29.78 ms) : 0, 29780
section profiling
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (768.544 ms) : 0, 768544
BytebuddyAgent [candidate] (762.81 ms) : 0, 762810
GlobalTracer [baseline] (234.82 ms) : 0, 234820
GlobalTracer [candidate] (233.25 ms) : 0, 233250
AppSec [baseline] (30.724 ms) : 0, 30724
AppSec [candidate] (31.955 ms) : 0, 31955
Debugger [baseline] (12.257 ms) : 0, 12257
Debugger [candidate] (11.319 ms) : 0, 11319
Remote Config [baseline] (730.675 µs) : 0, 731
Remote Config [candidate] (724.784 µs) : 0, 725
Telemetry [baseline] (10.201 ms) : 0, 10201
Telemetry [candidate] (10.227 ms) : 0, 10227
ProfilingAgent [baseline] (108.179 ms) : 0, 108179
ProfilingAgent [candidate] (107.726 ms) : 0, 107726
Profiling [baseline] (108.835 ms) : 0, 108835
Profiling [candidate] (108.371 ms) : 0, 108371
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~4039f5a53f, baseline=1.54.0-SNAPSHOT~3039978eaa
dateFormat X
axisFormat %s
section baseline
no_agent (4.438 ms) : 4384, 4492
. : milestone, 4438,
iast (9.401 ms) : 9249, 9554
. : milestone, 9401,
iast_FULL (14.457 ms) : 14168, 14745
. : milestone, 14457,
iast_GLOBAL (10.625 ms) : 10436, 10814
. : milestone, 10625,
profiling (9.026 ms) : 8880, 9173
. : milestone, 9026,
tracing (7.81 ms) : 7692, 7928
. : milestone, 7810,
section candidate
no_agent (4.454 ms) : 4402, 4505
. : milestone, 4454,
iast (9.363 ms) : 9210, 9517
. : milestone, 9363,
iast_FULL (14.326 ms) : 14033, 14618
. : milestone, 14326,
iast_GLOBAL (10.33 ms) : 10150, 10510
. : milestone, 10330,
profiling (8.442 ms) : 8316, 8569
. : milestone, 8442,
tracing (7.679 ms) : 7564, 7794
. : milestone, 7679,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~4039f5a53f, baseline=1.54.0-SNAPSHOT~3039978eaa
dateFormat X
axisFormat %s
section baseline
no_agent (34.898 ms) : 34618, 35177
. : milestone, 34898,
appsec (47.827 ms) : 47407, 48247
. : milestone, 47827,
code_origins (47.363 ms) : 46963, 47763
. : milestone, 47363,
iast (45.541 ms) : 45154, 45929
. : milestone, 45541,
profiling (48.643 ms) : 48213, 49073
. : milestone, 48643,
tracing (44.543 ms) : 44168, 44919
. : milestone, 44543,
section candidate
no_agent (37.42 ms) : 37121, 37719
. : milestone, 37420,
appsec (47.375 ms) : 46956, 47794
. : milestone, 47375,
code_origins (45.592 ms) : 45206, 45977
. : milestone, 45592,
iast (45.126 ms) : 44747, 45505
. : milestone, 45126,
profiling (46.966 ms) : 46503, 47429
. : milestone, 46966,
tracing (43.188 ms) : 42802, 43574
. : milestone, 43188,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~4039f5a53f, baseline=1.54.0-SNAPSHOT~3039978eaa
dateFormat X
axisFormat %s
section baseline
no_agent (14.924 s) : 14924000, 14924000
. : milestone, 14924000,
appsec (14.829 s) : 14829000, 14829000
. : milestone, 14829000,
iast (18.535 s) : 18535000, 18535000
. : milestone, 18535000,
iast_GLOBAL (18.089 s) : 18089000, 18089000
. : milestone, 18089000,
profiling (15.497 s) : 15497000, 15497000
. : milestone, 15497000,
tracing (14.883 s) : 14883000, 14883000
. : milestone, 14883000,
section candidate
no_agent (15.265 s) : 15265000, 15265000
. : milestone, 15265000,
appsec (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
iast (18.119 s) : 18119000, 18119000
. : milestone, 18119000,
iast_GLOBAL (18.112 s) : 18112000, 18112000
. : milestone, 18112000,
profiling (15.568 s) : 15568000, 15568000
. : milestone, 15568000,
tracing (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~4039f5a53f, baseline=1.54.0-SNAPSHOT~3039978eaa
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.652 ms) : 3437, 3867
. : milestone, 3652,
iast (2.192 ms) : 2130, 2255
. : milestone, 2192,
iast_GLOBAL (2.232 ms) : 2169, 2294
. : milestone, 2232,
profiling (2.056 ms) : 2004, 2107
. : milestone, 2056,
tracing (2.019 ms) : 1971, 2068
. : milestone, 2019,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.696 ms) : 3480, 3912
. : milestone, 3696,
iast (2.194 ms) : 2132, 2257
. : milestone, 2194,
iast_GLOBAL (2.231 ms) : 2168, 2294
. : milestone, 2231,
profiling (2.041 ms) : 1990, 2092
. : milestone, 2041,
tracing (2.016 ms) : 1967, 2065
. : milestone, 2016,
|
016ad50
to
c4ec313
Compare
c4ec313
to
4039f5a
Compare
What Does This Do
This provides the fix for the profiler smoke-tests when running on Oracle JDK 8
Motivation
Oracle JDK 8 JFR is storing the recordings compressed by GZip - our library detects that and avoids re-compression.
But this will cause issues when we try to decompress the gzip stream using zstd in the smoke tests.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issue