-
Notifications
You must be signed in to change notification settings - Fork 312
Implement Config Inversion with Default Strictness of Warning
#9539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mhlidd/migrate_config-utils_tests
Are you sure you want to change the base?
Implement Config Inversion with Default Strictness of Warning
#9539
Conversation
1a576ea
to
512b2c6
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~105e2d0f3f, baseline=1.54.0-SNAPSHOT~1052f4935d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065657
Total [baseline] (10.71 s) : 0, 10709997
Agent [candidate] (1.061 s) : 0, 1061324
Total [candidate] (10.821 s) : 0, 10820987
section appsec
Agent [baseline] (1.248 s) : 0, 1248405
Total [baseline] (11.094 s) : 0, 11093830
Agent [candidate] (1.238 s) : 0, 1237924
Total [candidate] (11.099 s) : 0, 11098686
section iast
Agent [baseline] (1.192 s) : 0, 1191595
Total [baseline] (11.025 s) : 0, 11024538
Agent [candidate] (1.191 s) : 0, 1191251
Total [candidate] (11.029 s) : 0, 11028834
section profiling
Agent [baseline] (1.211 s) : 0, 1211456
Total [baseline] (10.958 s) : 0, 10957920
Agent [candidate] (1.22 s) : 0, 1219582
Total [candidate] (10.971 s) : 0, 10971481
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~105e2d0f3f, baseline=1.54.0-SNAPSHOT~1052f4935d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (735.608 ms) : 0, 735608
BytebuddyAgent [candidate] (732.992 ms) : 0, 732992
GlobalTracer [baseline] (253.383 ms) : 0, 253383
GlobalTracer [candidate] (252.768 ms) : 0, 252768
AppSec [baseline] (30.572 ms) : 0, 30572
AppSec [candidate] (30.611 ms) : 0, 30611
Debugger [baseline] (6.393 ms) : 0, 6393
Debugger [candidate] (6.409 ms) : 0, 6409
Remote Config [baseline] (688.824 µs) : 0, 689
Remote Config [candidate] (685.725 µs) : 0, 686
Telemetry [baseline] (16.411 ms) : 0, 16411
Telemetry [candidate] (15.337 ms) : 0, 15337
section appsec
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (763.211 ms) : 0, 763211
BytebuddyAgent [candidate] (758.07 ms) : 0, 758070
GlobalTracer [baseline] (250.078 ms) : 0, 250078
GlobalTracer [candidate] (246.428 ms) : 0, 246428
AppSec [baseline] (172.64 ms) : 0, 172640
AppSec [candidate] (171.592 ms) : 0, 171592
Debugger [baseline] (6.132 ms) : 0, 6132
Debugger [candidate] (5.982 ms) : 0, 5982
Remote Config [baseline] (645.339 µs) : 0, 645
Remote Config [candidate] (620.539 µs) : 0, 621
Telemetry [baseline] (8.661 ms) : 0, 8661
Telemetry [candidate] (8.521 ms) : 0, 8521
IAST [baseline] (24.154 ms) : 0, 24154
IAST [candidate] (23.918 ms) : 0, 23918
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (851.662 ms) : 0, 851662
BytebuddyAgent [candidate] (851.781 ms) : 0, 851781
GlobalTracer [baseline] (246.85 ms) : 0, 246850
GlobalTracer [candidate] (248.041 ms) : 0, 248041
AppSec [baseline] (28.243 ms) : 0, 28243
AppSec [candidate] (24.501 ms) : 0, 24501
Debugger [baseline] (6.063 ms) : 0, 6063
Debugger [candidate] (6.064 ms) : 0, 6064
Remote Config [baseline] (619.234 µs) : 0, 619
Remote Config [candidate] (602.185 µs) : 0, 602
Telemetry [baseline] (8.154 ms) : 0, 8154
Telemetry [candidate] (8.138 ms) : 0, 8138
IAST [baseline] (27.402 ms) : 0, 27402
IAST [candidate] (29.654 ms) : 0, 29654
section profiling
ProfilingAgent [baseline] (108.711 ms) : 0, 108711
ProfilingAgent [candidate] (110.07 ms) : 0, 110070
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (761.914 ms) : 0, 761914
BytebuddyAgent [candidate] (766.749 ms) : 0, 766749
GlobalTracer [baseline] (233.62 ms) : 0, 233620
GlobalTracer [candidate] (234.658 ms) : 0, 234658
AppSec [baseline] (30.623 ms) : 0, 30623
AppSec [candidate] (30.741 ms) : 0, 30741
Debugger [baseline] (12.312 ms) : 0, 12312
Debugger [candidate] (13.869 ms) : 0, 13869
Remote Config [baseline] (1.485 ms) : 0, 1485
Remote Config [candidate] (718.598 µs) : 0, 719
Telemetry [baseline] (10.211 ms) : 0, 10211
Telemetry [candidate] (9.538 ms) : 0, 9538
Profiling [baseline] (109.344 ms) : 0, 109344
Profiling [candidate] (110.676 ms) : 0, 110676
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~105e2d0f3f, baseline=1.54.0-SNAPSHOT~1052f4935d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064332
Total [baseline] (8.689 s) : 0, 8689047
Agent [candidate] (1.064 s) : 0, 1064008
Total [candidate] (8.633 s) : 0, 8633044
section iast
Agent [baseline] (1.19 s) : 0, 1190450
Total [baseline] (9.293 s) : 0, 9292670
Agent [candidate] (1.193 s) : 0, 1192725
Total [candidate] (9.326 s) : 0, 9326343
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~105e2d0f3f, baseline=1.54.0-SNAPSHOT~1052f4935d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (734.143 ms) : 0, 734143
BytebuddyAgent [candidate] (733.988 ms) : 0, 733988
GlobalTracer [baseline] (253.767 ms) : 0, 253767
GlobalTracer [candidate] (253.14 ms) : 0, 253140
AppSec [baseline] (30.655 ms) : 0, 30655
AppSec [candidate] (30.626 ms) : 0, 30626
Debugger [baseline] (6.418 ms) : 0, 6418
Debugger [candidate] (6.412 ms) : 0, 6412
Remote Config [baseline] (698.825 µs) : 0, 699
Remote Config [candidate] (690.672 µs) : 0, 691
Telemetry [baseline] (16.082 ms) : 0, 16082
Telemetry [candidate] (16.603 ms) : 0, 16603
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (851.712 ms) : 0, 851712
BytebuddyAgent [candidate] (853.8 ms) : 0, 853800
GlobalTracer [baseline] (244.853 ms) : 0, 244853
GlobalTracer [candidate] (246.641 ms) : 0, 246641
IAST [baseline] (30.955 ms) : 0, 30955
IAST [candidate] (30.464 ms) : 0, 30464
AppSec [baseline] (25.483 ms) : 0, 25483
AppSec [candidate] (24.633 ms) : 0, 24633
Debugger [baseline] (6.101 ms) : 0, 6101
Debugger [candidate] (6.048 ms) : 0, 6048
Remote Config [baseline] (598.259 µs) : 0, 598
Remote Config [candidate] (592.891 µs) : 0, 593
Telemetry [baseline] (8.349 ms) : 0, 8349
Telemetry [candidate] (8.124 ms) : 0, 8124
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~105e2d0f3f, baseline=1.54.0-SNAPSHOT~1052f4935d
dateFormat X
axisFormat %s
section baseline
no_agent (4.332 ms) : 4281, 4383
. : milestone, 4332,
iast (9.518 ms) : 9362, 9673
. : milestone, 9518,
iast_FULL (14.758 ms) : 14463, 15054
. : milestone, 14758,
iast_GLOBAL (10.557 ms) : 10372, 10742
. : milestone, 10557,
profiling (9.223 ms) : 9076, 9369
. : milestone, 9223,
tracing (7.845 ms) : 7736, 7953
. : milestone, 7845,
section candidate
no_agent (4.22 ms) : 4170, 4270
. : milestone, 4220,
iast (9.384 ms) : 9231, 9537
. : milestone, 9384,
iast_FULL (14.146 ms) : 13864, 14428
. : milestone, 14146,
iast_GLOBAL (10.44 ms) : 10247, 10633
. : milestone, 10440,
profiling (9.6 ms) : 9421, 9779
. : milestone, 9600,
tracing (8.002 ms) : 7882, 8122
. : milestone, 8002,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~105e2d0f3f, baseline=1.54.0-SNAPSHOT~1052f4935d
dateFormat X
axisFormat %s
section baseline
no_agent (38.636 ms) : 38318, 38954
. : milestone, 38636,
appsec (48.218 ms) : 47784, 48651
. : milestone, 48218,
code_origins (45.706 ms) : 45314, 46098
. : milestone, 45706,
iast (46.001 ms) : 45594, 46407
. : milestone, 46001,
profiling (46.496 ms) : 46068, 46923
. : milestone, 46496,
tracing (46.077 ms) : 45657, 46496
. : milestone, 46077,
section candidate
no_agent (37.194 ms) : 36900, 37488
. : milestone, 37194,
appsec (49.474 ms) : 49062, 49887
. : milestone, 49474,
code_origins (46.705 ms) : 46310, 47101
. : milestone, 46705,
iast (44.847 ms) : 44460, 45233
. : milestone, 44847,
profiling (48.027 ms) : 47576, 48479
. : milestone, 48027,
tracing (43.613 ms) : 43239, 43988
. : milestone, 43613,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~105e2d0f3f, baseline=1.54.0-SNAPSHOT~1052f4935d
dateFormat X
axisFormat %s
section baseline
no_agent (15.497 s) : 15497000, 15497000
. : milestone, 15497000,
appsec (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
iast (18.62 s) : 18620000, 18620000
. : milestone, 18620000,
iast_GLOBAL (18.15 s) : 18150000, 18150000
. : milestone, 18150000,
profiling (16.055 s) : 16055000, 16055000
. : milestone, 16055000,
tracing (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
section candidate
no_agent (15.285 s) : 15285000, 15285000
. : milestone, 15285000,
appsec (14.702 s) : 14702000, 14702000
. : milestone, 14702000,
iast (18.629 s) : 18629000, 18629000
. : milestone, 18629000,
iast_GLOBAL (18.087 s) : 18087000, 18087000
. : milestone, 18087000,
profiling (15.318 s) : 15318000, 15318000
. : milestone, 15318000,
tracing (15.023 s) : 15023000, 15023000
. : milestone, 15023000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~105e2d0f3f, baseline=1.54.0-SNAPSHOT~1052f4935d
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.734 ms) : 3515, 3953
. : milestone, 3734,
iast (2.205 ms) : 2142, 2267
. : milestone, 2205,
iast_GLOBAL (2.262 ms) : 2199, 2326
. : milestone, 2262,
profiling (2.058 ms) : 2007, 2108
. : milestone, 2058,
tracing (2.046 ms) : 1997, 2096
. : milestone, 2046,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.71 ms) : 3496, 3925
. : milestone, 3710,
iast (2.216 ms) : 2153, 2279
. : milestone, 2216,
iast_GLOBAL (2.262 ms) : 2198, 2325
. : milestone, 2262,
profiling (2.052 ms) : 2002, 2103
. : milestone, 2052,
tracing (2.034 ms) : 1985, 2083
. : milestone, 2034,
|
🎯 Code Coverage 🔗 Commit SHA: 105e2d0 | Docs | Was this helpful? Give us feedback! |
Warning
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
aa18112
to
606dfd0
Compare
606dfd0
to
7cea99b
Compare
What Does This Do
This PR implements basic Config Inversion, aiming to document all DD/OTEL environment variables used in the repo in a
supported-configurations.json
file.Components:
ConfigInversionStrictStyle.java
Strict
which does not allow any usage of an unknown DD/OTEL environment variable,Warning
which allows the usage but sends telemetry about unknown environment variables, andTest
which allows the usage of unknown environment variables without sending telemetry.Warning
ConfigHelper.java
supported-configurations.json
to ensure the environment variable queried for is "known"ConfigInversionStrictStyle
that is set.Motivation
This PR supports the general Config Inversion theme that has already been implemented in dd-trace-js and currently being implemented in dd-trace-go and dd-trace-rb. Here is the RFC that documents what this project entails.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]