Skip to content

Group kafka instrumentations under a super module #9528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2025
Merged

Group kafka instrumentations under a super module #9528

merged 2 commits into from
Sep 16, 2025

Conversation

amarziali
Copy link
Contributor

@amarziali amarziali commented Sep 15, 2025 •
edited
Loading

What Does This Do

Group kafka instrumentation under a super module kafka.

Motivation

Additional Notes

Migrating to Instrumenter Module API will be done in a separate PR

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested review from a team as code owners September 15, 2025 09:11
@amarziali amarziali added tag: no release notes Changes to exclude from release notes type: refactoring inst: kafka Kafka instrumentation labels Sep 15, 2025
@amarziali amarziali requested a review from mcculls September 15, 2025 09:11
@amarziali amarziali enabled auto-merge (squash) September 15, 2025 09:12
@datadog-official Datadog Official
Copy link

datadog-official bot commented Sep 15, 2025 •
edited by datadog-datadog-prod-us1 bot
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 60.14% (-0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ec066d8 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 15, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/kafka
git_commit_date 1757953159 1757953594
git_commit_sha 8d08c36 ec066d8
release_version 1.54.0-SNAPSHOT~8d08c362b5 1.54.0-SNAPSHOT~ec066d818e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1757955281 1757955281
ci_job_id 1129568515 1129568515
ci_pipeline_id 76504713 76504713
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-cwwzy68y 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-cwwzy68y 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 8 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~ec066d818e, baseline=1.54.0-SNAPSHOT~8d08c362b5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073096
Total [baseline] (8.693 s) : 0, 8692663
Agent [candidate] (1.062 s) : 0, 1062226
Total [candidate] (8.656 s) : 0, 8655945
section iast
Agent [baseline] (1.19 s) : 0, 1190313
Total [baseline] (9.337 s) : 0, 9336573
Agent [candidate] (1.192 s) : 0, 1191799
Total [candidate] (9.319 s) : 0, 9319024
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent iast 1.19 s 117.217 ms (10.9%)
Total tracing 8.693 s -
Total iast 9.337 s 643.91 ms (7.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.192 s 129.573 ms (12.2%)
Total tracing 8.656 s -
Total iast 9.319 s 663.08 ms (7.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~ec066d818e, baseline=1.54.0-SNAPSHOT~8d08c362b5

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (741.442 ms) : 0, 741442
BytebuddyAgent [candidate] (733.522 ms) : 0, 733522
GlobalTracer [baseline] (254.677 ms) : 0, 254677
GlobalTracer [candidate] (252.354 ms) : 0, 252354
AppSec [baseline] (30.855 ms) : 0, 30855
AppSec [candidate] (30.577 ms) : 0, 30577
Debugger [baseline] (6.411 ms) : 0, 6411
Debugger [candidate] (6.389 ms) : 0, 6389
Remote Config [baseline] (690.176 µs) : 0, 690
Remote Config [candidate] (693.236 µs) : 0, 693
Telemetry [baseline] (16.386 ms) : 0, 16386
Telemetry [candidate] (16.231 ms) : 0, 16231
section iast
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (852.282 ms) : 0, 852282
BytebuddyAgent [candidate] (852.974 ms) : 0, 852974
GlobalTracer [baseline] (247.443 ms) : 0, 247443
GlobalTracer [candidate] (247.234 ms) : 0, 247234
IAST [baseline] (27.858 ms) : 0, 27858
IAST [candidate] (28.745 ms) : 0, 28745
AppSec [baseline] (25.54 ms) : 0, 25540
AppSec [candidate] (25.571 ms) : 0, 25571
Debugger [baseline] (6.046 ms) : 0, 6046
Debugger [candidate] (6.051 ms) : 0, 6051
Remote Config [baseline] (590.731 µs) : 0, 591
Remote Config [candidate] (597.116 µs) : 0, 597
Telemetry [baseline] (8.142 ms) : 0, 8142
Telemetry [candidate] (8.163 ms) : 0, 8163
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~ec066d818e, baseline=1.54.0-SNAPSHOT~8d08c362b5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064314
Total [baseline] (10.827 s) : 0, 10827171
Agent [candidate] (1.066 s) : 0, 1066298
Total [candidate] (10.701 s) : 0, 10701099
section appsec
Agent [baseline] (1.244 s) : 0, 1244032
Total [baseline] (11.056 s) : 0, 11056446
Agent [candidate] (1.245 s) : 0, 1244519
Total [candidate] (11.064 s) : 0, 11064342
section iast
Agent [baseline] (1.192 s) : 0, 1192000
Total [baseline] (11.028 s) : 0, 11027942
Agent [candidate] (1.209 s) : 0, 1208900
Total [candidate] (11.121 s) : 0, 11121248
section profiling
Agent [baseline] (1.222 s) : 0, 1221880
Total [baseline] (11.118 s) : 0, 11118148
Agent [candidate] (1.21 s) : 0, 1210177
Total [candidate] (11.016 s) : 0, 11015875
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.244 s 179.718 ms (16.9%)
Agent iast 1.192 s 127.686 ms (12.0%)
Agent profiling 1.222 s 157.566 ms (14.8%)
Total tracing 10.827 s -
Total appsec 11.056 s 229.275 ms (2.1%)
Total iast 11.028 s 200.771 ms (1.9%)
Total profiling 11.118 s 290.977 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.245 s 178.222 ms (16.7%)
Agent iast 1.209 s 142.602 ms (13.4%)
Agent profiling 1.21 s 143.879 ms (13.5%)
Total tracing 10.701 s -
Total appsec 11.064 s 363.243 ms (3.4%)
Total iast 11.121 s 420.149 ms (3.9%)
Total profiling 11.016 s 314.776 ms (2.9%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~ec066d818e, baseline=1.54.0-SNAPSHOT~8d08c362b5

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (735.462 ms) : 0, 735462
BytebuddyAgent [candidate] (736.083 ms) : 0, 736083
GlobalTracer [baseline] (252.909 ms) : 0, 252909
GlobalTracer [candidate] (253.475 ms) : 0, 253475
AppSec [baseline] (30.539 ms) : 0, 30539
AppSec [candidate] (30.624 ms) : 0, 30624
Debugger [baseline] (6.388 ms) : 0, 6388
Debugger [candidate] (6.384 ms) : 0, 6384
Remote Config [baseline] (697.321 µs) : 0, 697
Remote Config [candidate] (696.703 µs) : 0, 697
Telemetry [baseline] (15.579 ms) : 0, 15579
Telemetry [candidate] (16.35 ms) : 0, 16350
section appsec
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (761.648 ms) : 0, 761648
BytebuddyAgent [candidate] (762.597 ms) : 0, 762597
GlobalTracer [baseline] (247.681 ms) : 0, 247681
GlobalTracer [candidate] (247.748 ms) : 0, 247748
IAST [baseline] (23.829 ms) : 0, 23829
IAST [candidate] (24.027 ms) : 0, 24027
AppSec [baseline] (172.701 ms) : 0, 172701
AppSec [candidate] (172.163 ms) : 0, 172163
Debugger [baseline] (6.091 ms) : 0, 6091
Debugger [candidate] (6.022 ms) : 0, 6022
Remote Config [baseline] (651.592 µs) : 0, 652
Remote Config [candidate] (635.372 µs) : 0, 635
Telemetry [baseline] (8.544 ms) : 0, 8544
Telemetry [candidate] (8.434 ms) : 0, 8434
section iast
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (852.89 ms) : 0, 852890
BytebuddyAgent [candidate] (867.252 ms) : 0, 867252
GlobalTracer [baseline] (247.159 ms) : 0, 247159
GlobalTracer [candidate] (247.513 ms) : 0, 247513
IAST [baseline] (28.983 ms) : 0, 28983
IAST [candidate] (29.98 ms) : 0, 29980
AppSec [baseline] (25.607 ms) : 0, 25607
AppSec [candidate] (26.292 ms) : 0, 26292
Debugger [baseline] (6.12 ms) : 0, 6120
Debugger [candidate] (6.139 ms) : 0, 6139
Remote Config [baseline] (595.608 µs) : 0, 596
Remote Config [candidate] (597.125 µs) : 0, 597
Telemetry [baseline] (8.117 ms) : 0, 8117
Telemetry [candidate] (8.327 ms) : 0, 8327
section profiling
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (769.185 ms) : 0, 769185
BytebuddyAgent [candidate] (762.132 ms) : 0, 762132
GlobalTracer [baseline] (235.563 ms) : 0, 235563
GlobalTracer [candidate] (233.197 ms) : 0, 233197
AppSec [baseline] (31.545 ms) : 0, 31545
AppSec [candidate] (30.432 ms) : 0, 30432
Debugger [baseline] (7.442 ms) : 0, 7442
Debugger [candidate] (7.45 ms) : 0, 7450
Remote Config [baseline] (1.568 ms) : 0, 1568
Remote Config [candidate] (712.99 µs) : 0, 713
Telemetry [baseline] (14.6 ms) : 0, 14600
Telemetry [candidate] (15.654 ms) : 0, 15654
ProfilingAgent [baseline] (108.926 ms) : 0, 108926
ProfilingAgent [candidate] (107.933 ms) : 0, 107933
Profiling [baseline] (109.551 ms) : 0, 109551
Profiling [candidate] (108.589 ms) : 0, 108589
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/kafka
git_commit_date 1757953159 1757953594
git_commit_sha 8d08c36 ec066d8
release_version 1.54.0-SNAPSHOT~8d08c362b5 1.54.0-SNAPSHOT~ec066d818e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1757955023 1757955023
ci_job_id 1129568516 1129568516
ci_pipeline_id 76504713 76504713
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-9uene711 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-9uene711 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load worse
[+242.192µs; +350.259µs] or [+5.756%; +8.324%]		 unstable
[-180.353op/s; +40.290op/s] or [-16.554%; +3.698%]		 4.504ms 1019.438op/s 4.208ms 1089.469op/s
scenario:load:insecure-bank:iast_FULL:high_load worse
[+353.872µs; +981.475µs] or [+2.521%; +6.991%]		 unstable
[-48.677op/s; +18.864op/s] or [-14.667%; +5.684%]		 14.707ms 316.969op/s 14.039ms 331.875op/s
scenario:load:petclinic:no_agent:high_load worse
[+1.382ms; +2.020ms] or [+3.805%; +5.563%]		 unstable
[-15.089op/s; +3.639op/s] or [-11.720%; +2.827%]		 38.004ms 123.025op/s 36.304ms 128.750op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~ec066d818e, baseline=1.54.0-SNAPSHOT~8d08c362b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.304 ms) : 36011, 36596
.   : milestone, 36304,
appsec (47.338 ms) : 46919, 47756
.   : milestone, 47338,
code_origins (44.803 ms) : 44419, 45187
.   : milestone, 44803,
iast (44.515 ms) : 44126, 44905
.   : milestone, 44515,
profiling (48.927 ms) : 48447, 49408
.   : milestone, 48927,
tracing (45.062 ms) : 44679, 45444
.   : milestone, 45062,
section candidate
no_agent (38.004 ms) : 37704, 38305
.   : milestone, 38004,
appsec (48.345 ms) : 47928, 48762
.   : milestone, 48345,
code_origins (44.45 ms) : 44075, 44826
.   : milestone, 44450,
iast (44.504 ms) : 44120, 44888
.   : milestone, 44504,
profiling (50.229 ms) : 49790, 50668
.   : milestone, 50229,
tracing (43.769 ms) : 43388, 44149
.   : milestone, 43769,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.304 ms [36.011 ms, 36.596 ms] -
appsec 47.338 ms [46.919 ms, 47.756 ms] 11.034 ms (30.4%)
code_origins 44.803 ms [44.419 ms, 45.187 ms] 8.499 ms (23.4%)
iast 44.515 ms [44.126 ms, 44.905 ms] 8.212 ms (22.6%)
profiling 48.927 ms [48.447 ms, 49.408 ms] 12.624 ms (34.8%)
tracing 45.062 ms [44.679 ms, 45.444 ms] 8.758 ms (24.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 38.004 ms [37.704 ms, 38.305 ms] -
appsec 48.345 ms [47.928 ms, 48.762 ms] 10.341 ms (27.2%)
code_origins 44.45 ms [44.075 ms, 44.826 ms] 6.446 ms (17.0%)
iast 44.504 ms [44.12 ms, 44.888 ms] 6.5 ms (17.1%)
profiling 50.229 ms [49.79 ms, 50.668 ms] 12.224 ms (32.2%)
tracing 43.769 ms [43.388 ms, 44.149 ms] 5.764 ms (15.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~ec066d818e, baseline=1.54.0-SNAPSHOT~8d08c362b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.208 ms) : 4158, 4257
.   : milestone, 4208,
iast (9.676 ms) : 9511, 9840
.   : milestone, 9676,
iast_FULL (14.039 ms) : 13755, 14324
.   : milestone, 14039,
iast_GLOBAL (10.41 ms) : 10214, 10606
.   : milestone, 10410,
profiling (9.017 ms) : 8876, 9158
.   : milestone, 9017,
tracing (7.836 ms) : 7723, 7948
.   : milestone, 7836,
section candidate
no_agent (4.504 ms) : 4453, 4555
.   : milestone, 4504,
iast (9.428 ms) : 9274, 9583
.   : milestone, 9428,
iast_FULL (14.707 ms) : 14409, 15005
.   : milestone, 14707,
iast_GLOBAL (10.791 ms) : 10596, 10986
.   : milestone, 10791,
profiling (8.794 ms) : 8658, 8930
.   : milestone, 8794,
tracing (7.688 ms) : 7570, 7806
.   : milestone, 7688,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.208 ms [4.158 ms, 4.257 ms] -
iast 9.676 ms [9.511 ms, 9.84 ms] 5.468 ms (130.0%)
iast_FULL 14.039 ms [13.755 ms, 14.324 ms] 9.832 ms (233.7%)
iast_GLOBAL 10.41 ms [10.214 ms, 10.606 ms] 6.202 ms (147.4%)
profiling 9.017 ms [8.876 ms, 9.158 ms] 4.81 ms (114.3%)
tracing 7.836 ms [7.723 ms, 7.948 ms] 3.628 ms (86.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.504 ms [4.453 ms, 4.555 ms] -
iast 9.428 ms [9.274 ms, 9.583 ms] 4.924 ms (109.3%)
iast_FULL 14.707 ms [14.409 ms, 15.005 ms] 10.203 ms (226.5%)
iast_GLOBAL 10.791 ms [10.596 ms, 10.986 ms] 6.287 ms (139.6%)
profiling 8.794 ms [8.658 ms, 8.93 ms] 4.29 ms (95.3%)
tracing 7.688 ms [7.57 ms, 7.806 ms] 3.184 ms (70.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/kafka
git_commit_date 1757953159 1757953594
git_commit_sha 8d08c36 ec066d8
release_version 1.54.0-SNAPSHOT~8d08c362b5 1.54.0-SNAPSHOT~ec066d818e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1757955529 1757955529
ci_job_id 1129568517 1129568517
ci_pipeline_id 76504713 76504713
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-obaq72ie 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-obaq72ie 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~ec066d818e, baseline=1.54.0-SNAPSHOT~8d08c362b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.951 s) : 14951000, 14951000
.   : milestone, 14951000,
appsec (15.063 s) : 15063000, 15063000
.   : milestone, 15063000,
iast (18.297 s) : 18297000, 18297000
.   : milestone, 18297000,
iast_GLOBAL (18.204 s) : 18204000, 18204000
.   : milestone, 18204000,
profiling (15.665 s) : 15665000, 15665000
.   : milestone, 15665000,
tracing (15.014 s) : 15014000, 15014000
.   : milestone, 15014000,
section candidate
no_agent (14.991 s) : 14991000, 14991000
.   : milestone, 14991000,
appsec (14.834 s) : 14834000, 14834000
.   : milestone, 14834000,
iast (18.473 s) : 18473000, 18473000
.   : milestone, 18473000,
iast_GLOBAL (17.95 s) : 17950000, 17950000
.   : milestone, 17950000,
profiling (15.37 s) : 15370000, 15370000
.   : milestone, 15370000,
tracing (15.023 s) : 15023000, 15023000
.   : milestone, 15023000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.951 s [14.951 s, 14.951 s] -
appsec 15.063 s [15.063 s, 15.063 s] 112.0 ms (0.7%)
iast 18.297 s [18.297 s, 18.297 s] 3.346 s (22.4%)
iast_GLOBAL 18.204 s [18.204 s, 18.204 s] 3.253 s (21.8%)
profiling 15.665 s [15.665 s, 15.665 s] 714.0 ms (4.8%)
tracing 15.014 s [15.014 s, 15.014 s] 63.0 ms (0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.991 s [14.991 s, 14.991 s] -
appsec 14.834 s [14.834 s, 14.834 s] -157.0 ms (-1.0%)
iast 18.473 s [18.473 s, 18.473 s] 3.482 s (23.2%)
iast_GLOBAL 17.95 s [17.95 s, 17.95 s] 2.959 s (19.7%)
profiling 15.37 s [15.37 s, 15.37 s] 379.0 ms (2.5%)
tracing 15.023 s [15.023 s, 15.023 s] 32.0 ms (0.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~ec066d818e, baseline=1.54.0-SNAPSHOT~8d08c362b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (2.513 ms) : 2459, 2566
.   : milestone, 2513,
iast (2.209 ms) : 2147, 2272
.   : milestone, 2209,
iast_GLOBAL (2.251 ms) : 2189, 2314
.   : milestone, 2251,
profiling (2.06 ms) : 2008, 2112
.   : milestone, 2060,
tracing (2.022 ms) : 1973, 2071
.   : milestone, 2022,
section candidate
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (3.733 ms) : 3515, 3951
.   : milestone, 3733,
iast (2.205 ms) : 2142, 2268
.   : milestone, 2205,
iast_GLOBAL (2.251 ms) : 2188, 2314
.   : milestone, 2251,
profiling (2.468 ms) : 2313, 2624
.   : milestone, 2468,
tracing (2.011 ms) : 1962, 2060
.   : milestone, 2011,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.481 ms [1.47 ms, 1.493 ms] -
appsec 2.513 ms [2.459 ms, 2.566 ms] 1.031 ms (69.6%)
iast 2.209 ms [2.147 ms, 2.272 ms] 727.766 µs (49.1%)
iast_GLOBAL 2.251 ms [2.189 ms, 2.314 ms] 769.967 µs (52.0%)
profiling 2.06 ms [2.008 ms, 2.112 ms] 578.732 µs (39.1%)
tracing 2.022 ms [1.973 ms, 2.071 ms] 540.681 µs (36.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.465 ms, 1.488 ms] -
appsec 3.733 ms [3.515 ms, 3.951 ms] 2.256 ms (152.8%)
iast 2.205 ms [2.142 ms, 2.268 ms] 727.936 µs (49.3%)
iast_GLOBAL 2.251 ms [2.188 ms, 2.314 ms] 774.204 µs (52.4%)
profiling 2.468 ms [2.313 ms, 2.624 ms] 991.346 µs (67.1%)
tracing 2.011 ms [1.962 ms, 2.06 ms] 534.085 µs (36.2%)

PerfectSlayer
PerfectSlayer approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏Thanks for the refactoring

@amarziali amarziali merged commit 2d42e7c into master Sep 16, 2025
500 checks passed
@amarziali amarziali deleted the andrea.marziali/kafka branch September 16, 2025 09:53
@github-actions github-actions bot added this to the 1.54.0 milestone Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@robertpi robertpi Awaiting requested review from robertpi robertpi is a code owner automatically assigned from DataDog/asm-java

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: kafka Kafka instrumentation tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @PerfectSlayer