Resilience4j 2.x #9525
Draft
Resilience4j 2.x #9525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up CircuitBreakerInstrumentation
…ion. Fix muzzle check by excluding helper classes referencing an instrumented interface. Extracted Resilience4jInstrumentation.
Minimize number of necessary wrapper. Get rid of the muzzle problem caused by a wrapper extending an instrumented interface.
…or span finishing
Add sync retry test.
Pass the context holder at creation time. TODO: Implement this for all types of combinators and eliminate reliance on the active span.
Pass the context holder at creation time. TODO: Implement this for tracedCompletionStage
Pass the context holder at creation time.
…tead of trying to build a common context holder at a decorator construction time. This should simplify the solution and make it less prone to missing instrumentation and easier to apply to other integration like reactor, javarx, etc.
…t and replace with ?
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~e081b7d22a, baseline=1.54.0-SNAPSHOT~8d08c362b5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069012
Total [baseline] (10.843 s) : 0, 10842747
Agent [candidate] (1.065 s) : 0, 1065399
Total [candidate] (10.785 s) : 0, 10784861
section appsec
Agent [baseline] (1.253 s) : 0, 1252659
Total [baseline] (11.134 s) : 0, 11134495
Agent [candidate] (1.241 s) : 0, 1241383
Total [candidate] (11.032 s) : 0, 11031846
section iast
Agent [baseline] (1.194 s) : 0, 1193836
Total [baseline] (10.996 s) : 0, 10996459
Agent [candidate] (1.2 s) : 0, 1200158
Total [candidate] (11.201 s) : 0, 11201322
section profiling
Agent [baseline] (1.212 s) : 0, 1211815
Total [baseline] (11.022 s) : 0, 11022169
Agent [candidate] (1.216 s) : 0, 1215635
Total [candidate] (10.948 s) : 0, 10948162
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~e081b7d22a, baseline=1.54.0-SNAPSHOT~8d08c362b5
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (738.45 ms) : 0, 738450
BytebuddyAgent [candidate] (736.097 ms) : 0, 736097
GlobalTracer [baseline] (254.381 ms) : 0, 254381
GlobalTracer [candidate] (252.621 ms) : 0, 252621
AppSec [baseline] (30.752 ms) : 0, 30752
AppSec [candidate] (30.64 ms) : 0, 30640
Debugger [baseline] (6.381 ms) : 0, 6381
Debugger [candidate] (6.364 ms) : 0, 6364
Remote Config [baseline] (691.211 µs) : 0, 691
Remote Config [candidate] (673.815 µs) : 0, 674
Telemetry [baseline] (15.589 ms) : 0, 15589
Telemetry [candidate] (16.403 ms) : 0, 16403
section appsec
crashtracking [baseline] (1.493 ms) : 0, 1493
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (768.109 ms) : 0, 768109
BytebuddyAgent [candidate] (760.115 ms) : 0, 760115
GlobalTracer [baseline] (249.093 ms) : 0, 249093
GlobalTracer [candidate] (246.121 ms) : 0, 246121
IAST [baseline] (24.167 ms) : 0, 24167
IAST [candidate] (23.68 ms) : 0, 23680
AppSec [baseline] (172.936 ms) : 0, 172936
AppSec [candidate] (173.162 ms) : 0, 173162
Debugger [baseline] (6.132 ms) : 0, 6132
Debugger [candidate] (6.087 ms) : 0, 6087
Remote Config [baseline] (641.994 µs) : 0, 642
Remote Config [candidate] (634.691 µs) : 0, 635
Telemetry [baseline] (8.603 ms) : 0, 8603
Telemetry [candidate] (8.787 ms) : 0, 8787
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (854.448 ms) : 0, 854448
BytebuddyAgent [candidate] (861.462 ms) : 0, 861462
GlobalTracer [baseline] (248.324 ms) : 0, 248324
GlobalTracer [candidate] (251.273 ms) : 0, 251273
IAST [baseline] (27.154 ms) : 0, 27154
IAST [candidate] (25.488 ms) : 0, 25488
AppSec [baseline] (25.552 ms) : 0, 25552
AppSec [candidate] (24.568 ms) : 0, 24568
Debugger [baseline] (6.068 ms) : 0, 6068
Debugger [candidate] (6.073 ms) : 0, 6073
Remote Config [baseline] (605.015 µs) : 0, 605
Remote Config [candidate] (604.893 µs) : 0, 605
Telemetry [baseline] (8.96 ms) : 0, 8960
Telemetry [candidate] (8.207 ms) : 0, 8207
section profiling
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (763.0 ms) : 0, 763000
BytebuddyAgent [candidate] (764.946 ms) : 0, 764946
GlobalTracer [baseline] (233.884 ms) : 0, 233884
GlobalTracer [candidate] (234.356 ms) : 0, 234356
AppSec [baseline] (30.488 ms) : 0, 30488
AppSec [candidate] (30.884 ms) : 0, 30884
Debugger [baseline] (7.381 ms) : 0, 7381
Debugger [candidate] (12.778 ms) : 0, 12778
Remote Config [baseline] (3.05 ms) : 0, 3050
Remote Config [candidate] (699.262 µs) : 0, 699
Telemetry [baseline] (13.374 ms) : 0, 13374
Telemetry [candidate] (10.322 ms) : 0, 10322
ProfilingAgent [baseline] (107.955 ms) : 0, 107955
ProfilingAgent [candidate] (109.052 ms) : 0, 109052
Profiling [baseline] (108.599 ms) : 0, 108599
Profiling [candidate] (109.687 ms) : 0, 109687
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~e081b7d22a, baseline=1.54.0-SNAPSHOT~8d08c362b5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1077098
Total [baseline] (8.658 s) : 0, 8657604
Agent [candidate] (1.073 s) : 0, 1072621
Total [candidate] (8.659 s) : 0, 8658594
section iast
Agent [baseline] (1.192 s) : 0, 1192241
Total [baseline] (9.336 s) : 0, 9336421
Agent [candidate] (1.193 s) : 0, 1192774
Total [candidate] (9.354 s) : 0, 9354151
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~e081b7d22a, baseline=1.54.0-SNAPSHOT~8d08c362b5
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (743.833 ms) : 0, 743833
BytebuddyAgent [candidate] (741.133 ms) : 0, 741133
GlobalTracer [baseline] (255.635 ms) : 0, 255635
GlobalTracer [candidate] (254.373 ms) : 0, 254373
AppSec [baseline] (31.13 ms) : 0, 31130
AppSec [candidate] (30.965 ms) : 0, 30965
Debugger [baseline] (6.473 ms) : 0, 6473
Debugger [candidate] (6.433 ms) : 0, 6433
Remote Config [baseline] (714.197 µs) : 0, 714
Remote Config [candidate] (678.361 µs) : 0, 678
Telemetry [baseline] (16.53 ms) : 0, 16530
Telemetry [candidate] (16.373 ms) : 0, 16373
section iast
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (853.508 ms) : 0, 853508
BytebuddyAgent [candidate] (855.155 ms) : 0, 855155
GlobalTracer [baseline] (246.22 ms) : 0, 246220
GlobalTracer [candidate] (247.235 ms) : 0, 247235
IAST [baseline] (29.646 ms) : 0, 29646
IAST [candidate] (28.637 ms) : 0, 28637
AppSec [baseline] (25.658 ms) : 0, 25658
AppSec [candidate] (24.496 ms) : 0, 24496
Debugger [baseline] (6.022 ms) : 0, 6022
Debugger [candidate] (6.033 ms) : 0, 6033
Remote Config [baseline] (602.359 µs) : 0, 602
Remote Config [candidate] (593.525 µs) : 0, 594
Telemetry [baseline] (8.133 ms) : 0, 8133
Telemetry [candidate] (8.222 ms) : 0, 8222
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~e081b7d22a, baseline=1.54.0-SNAPSHOT~8d08c362b5
dateFormat X
axisFormat %s
section baseline
no_agent (4.383 ms) : 4332, 4434
. : milestone, 4383,
iast (9.348 ms) : 9194, 9502
. : milestone, 9348,
iast_FULL (14.233 ms) : 13949, 14517
. : milestone, 14233,
iast_GLOBAL (10.634 ms) : 10427, 10840
. : milestone, 10634,
profiling (9.003 ms) : 8862, 9143
. : milestone, 9003,
tracing (7.862 ms) : 7751, 7974
. : milestone, 7862,
section candidate
no_agent (4.27 ms) : 4216, 4324
. : milestone, 4270,
iast (9.129 ms) : 8980, 9278
. : milestone, 9129,
iast_FULL (14.538 ms) : 14248, 14829
. : milestone, 14538,
iast_GLOBAL (10.81 ms) : 10614, 11006
. : milestone, 10810,
profiling (8.905 ms) : 8756, 9054
. : milestone, 8905,
tracing (7.927 ms) : 7801, 8052
. : milestone, 7927,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~e081b7d22a, baseline=1.54.0-SNAPSHOT~8d08c362b5
dateFormat X
axisFormat %s
section baseline
no_agent (37.521 ms) : 37217, 37824
. : milestone, 37521,
appsec (47.842 ms) : 47432, 48251
. : milestone, 47842,
code_origins (44.702 ms) : 44314, 45091
. : milestone, 44702,
iast (46.02 ms) : 45619, 46421
. : milestone, 46020,
profiling (47.166 ms) : 46726, 47606
. : milestone, 47166,
tracing (44.287 ms) : 43922, 44653
. : milestone, 44287,
section candidate
no_agent (36.232 ms) : 35953, 36512
. : milestone, 36232,
appsec (48.709 ms) : 48273, 49145
. : milestone, 48709,
code_origins (44.253 ms) : 43864, 44642
. : milestone, 44253,
iast (46.172 ms) : 45770, 46574
. : milestone, 46172,
profiling (48.319 ms) : 47893, 48746
. : milestone, 48319,
tracing (45.144 ms) : 44764, 45523
. : milestone, 45144,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~e081b7d22a, baseline=1.54.0-SNAPSHOT~8d08c362b5
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.683 ms) : 3467, 3899
. : milestone, 3683,
iast (2.195 ms) : 2133, 2258
. : milestone, 2195,
iast_GLOBAL (2.24 ms) : 2177, 2303
. : milestone, 2240,
profiling (2.054 ms) : 2003, 2106
. : milestone, 2054,
tracing (2.015 ms) : 1966, 2064
. : milestone, 2015,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.652 ms) : 3439, 3865
. : milestone, 3652,
iast (2.203 ms) : 2140, 2266
. : milestone, 2203,
iast_GLOBAL (2.255 ms) : 2191, 2320
. : milestone, 2255,
profiling (2.042 ms) : 1991, 2093
. : milestone, 2042,
tracing (2.023 ms) : 1973, 2072
. : milestone, 2023,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~e081b7d22a, baseline=1.54.0-SNAPSHOT~8d08c362b5
dateFormat X
axisFormat %s
section baseline
no_agent (15.419 s) : 15419000, 15419000
. : milestone, 15419000,
appsec (14.811 s) : 14811000, 14811000
. : milestone, 14811000,
iast (18.634 s) : 18634000, 18634000
. : milestone, 18634000,
iast_GLOBAL (17.945 s) : 17945000, 17945000
. : milestone, 17945000,
profiling (15.416 s) : 15416000, 15416000
. : milestone, 15416000,
tracing (14.771 s) : 14771000, 14771000
. : milestone, 14771000,
section candidate
no_agent (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
appsec (14.802 s) : 14802000, 14802000
. : milestone, 14802000,
iast (18.202 s) : 18202000, 18202000
. : milestone, 18202000,
iast_GLOBAL (17.79 s) : 17790000, 17790000
. : milestone, 17790000,
profiling (15.376 s) : 15376000, 15376000
. : milestone, 15376000,
tracing (14.804 s) : 14804000, 14804000
. : milestone, 14804000,
|
|
🎯 Code Coverage 🔗 Commit SHA: e081b7d | Docs | Was this helpful? Give us feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: OLDAIDM-540