Skip to content

Upload code coverage to Datadog #9132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 10, 2025
Merged

Upload code coverage to Datadog #9132

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77725ca
Upload code coverage to Datadog
nikita-tkachenko-datadog Jul 9, 2025
8c59b29
Ignore symbolic links for now as they break datadog-ci path scanning
nikita-tkachenko-datadog Jul 9, 2025
8d7f252
Fix repo URL
nikita-tkachenko-datadog Jul 10, 2025
0cf18da
Fix upload command
nikita-tkachenko-datadog Jul 10, 2025
150b8c0
Consider status of both JUnit upload and Coverage upload
nikita-tkachenko-datadog Jul 10, 2025
b4c50a4
Fix naming error
nikita-tkachenko-datadog Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .gitlab/upload_ciapp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,20 @@ junit_upload() {
./results
}

# Upload code coverage results to Datadog
coverage_upload() {
DD_API_KEY=$1 \
[email protected]:DataDog/dd-trace-java.git \
datadog-ci coverage upload --ignored-paths=./test-published-dependencies .
}

# Upload test results to production environment like all other CI jobs
junit_upload "$DATADOG_API_KEY_PROD"
junit_upload_status=$?

coverage_upload "$DATADOG_API_KEY_PROD"
Copy link
Contributor

@PerfectSlayer PerfectSlayer Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the script return the result of both upload functions now? Not only the coverage one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't it just fail if any of the uploads fails?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nevermind, I realised the default is to just continue executing if a command fails. Updated the script to consider both statuses

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment here: https://github.com/DataDog/dd-trace-java/pull/9132/files#r2197581837

coverage_upload_status=$?

if [[ $junit_upload_status -ne 0 || $coverage_upload_status -ne 0 ]]; then
exit 1
fi