-
Notifications
You must be signed in to change notification settings - Fork 312
Fix the profiler stackdepth setting propagation in recent (22+) Java versions #9130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
207432a
to
a58696a
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~7283b8f4e8, baseline=1.51.1-SNAPSHOT~b94ca598bb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1040250
Total [baseline] (8.561 s) : 0, 8560660
Agent [candidate] (1.041 s) : 0, 1040517
Total [candidate] (8.601 s) : 0, 8600841
section iast
Agent [baseline] (1.182 s) : 0, 1181946
Total [baseline] (9.347 s) : 0, 9346949
Agent [candidate] (1.172 s) : 0, 1172051
Total [candidate] (9.292 s) : 0, 9291773
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~7283b8f4e8, baseline=1.51.1-SNAPSHOT~b94ca598bb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (728.542 ms) : 0, 728542
BytebuddyAgent [candidate] (728.6 ms) : 0, 728600
GlobalTracer [baseline] (241.287 ms) : 0, 241287
GlobalTracer [candidate] (240.635 ms) : 0, 240635
AppSec [baseline] (30.324 ms) : 0, 30324
AppSec [candidate] (30.338 ms) : 0, 30338
Debugger [baseline] (5.961 ms) : 0, 5961
Debugger [candidate] (5.959 ms) : 0, 5959
Remote Config [baseline] (644.933 µs) : 0, 645
Remote Config [candidate] (647.649 µs) : 0, 648
Telemetry [baseline] (11.139 ms) : 0, 11139
Telemetry [candidate] (11.946 ms) : 0, 11946
section iast
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (854.165 ms) : 0, 854165
BytebuddyAgent [candidate] (845.617 ms) : 0, 845617
GlobalTracer [baseline] (232.508 ms) : 0, 232508
GlobalTracer [candidate] (231.154 ms) : 0, 231154
IAST [baseline] (30.012 ms) : 0, 30012
IAST [candidate] (28.364 ms) : 0, 28364
AppSec [baseline] (26.635 ms) : 0, 26635
AppSec [candidate] (28.255 ms) : 0, 28255
Debugger [baseline] (7.587 ms) : 0, 7587
Debugger [candidate] (7.5 ms) : 0, 7500
Remote Config [baseline] (580.933 µs) : 0, 581
Remote Config [candidate] (585.097 µs) : 0, 585
Telemetry [baseline] (8.033 ms) : 0, 8033
Telemetry [candidate] (8.217 ms) : 0, 8217
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~7283b8f4e8, baseline=1.51.1-SNAPSHOT~b94ca598bb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1039915
Total [baseline] (10.754 s) : 0, 10754036
Agent [candidate] (1.042 s) : 0, 1041986
Total [candidate] (10.699 s) : 0, 10699140
section appsec
Agent [baseline] (1.218 s) : 0, 1217608
Total [baseline] (10.746 s) : 0, 10745588
Agent [candidate] (1.224 s) : 0, 1224418
Total [candidate] (10.768 s) : 0, 10768309
section iast
Agent [baseline] (1.177 s) : 0, 1176687
Total [baseline] (10.908 s) : 0, 10908055
Agent [candidate] (1.173 s) : 0, 1173209
Total [candidate] (10.868 s) : 0, 10867582
section profiling
Agent [baseline] (1.19 s) : 0, 1189547
Total [baseline] (10.84 s) : 0, 10839504
Agent [candidate] (1.195 s) : 0, 1195166
Total [candidate] (10.925 s) : 0, 10925041
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~7283b8f4e8, baseline=1.51.1-SNAPSHOT~b94ca598bb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.419 ms) : 0, 1419
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (727.579 ms) : 0, 727579
BytebuddyAgent [candidate] (729.487 ms) : 0, 729487
GlobalTracer [baseline] (240.522 ms) : 0, 240522
GlobalTracer [candidate] (241.127 ms) : 0, 241127
AppSec [baseline] (30.271 ms) : 0, 30271
AppSec [candidate] (30.499 ms) : 0, 30499
Debugger [baseline] (5.971 ms) : 0, 5971
Debugger [candidate] (5.953 ms) : 0, 5953
Remote Config [baseline] (647.766 µs) : 0, 648
Remote Config [candidate] (655.724 µs) : 0, 656
Telemetry [baseline] (12.572 ms) : 0, 12572
Telemetry [candidate] (11.832 ms) : 0, 11832
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (751.989 ms) : 0, 751989
BytebuddyAgent [candidate] (755.987 ms) : 0, 755987
GlobalTracer [baseline] (234.247 ms) : 0, 234247
GlobalTracer [candidate] (235.854 ms) : 0, 235854
AppSec [baseline] (169.982 ms) : 0, 169982
AppSec [candidate] (168.644 ms) : 0, 168644
Debugger [baseline] (6.362 ms) : 0, 6362
Debugger [candidate] (8.484 ms) : 0, 8484
Remote Config [baseline] (605.587 µs) : 0, 606
Remote Config [candidate] (614.902 µs) : 0, 615
Telemetry [baseline] (8.221 ms) : 0, 8221
Telemetry [candidate] (8.293 ms) : 0, 8293
IAST [baseline] (23.504 ms) : 0, 23504
IAST [candidate] (23.723 ms) : 0, 23723
section iast
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (850.35 ms) : 0, 850350
BytebuddyAgent [candidate] (847.417 ms) : 0, 847417
GlobalTracer [baseline] (231.5 ms) : 0, 231500
GlobalTracer [candidate] (231.573 ms) : 0, 231573
AppSec [baseline] (28.286 ms) : 0, 28286
AppSec [candidate] (26.35 ms) : 0, 26350
Debugger [baseline] (6.61 ms) : 0, 6610
Debugger [candidate] (5.751 ms) : 0, 5751
Remote Config [baseline] (592.496 µs) : 0, 592
Remote Config [candidate] (582.468 µs) : 0, 582
Telemetry [baseline] (8.09 ms) : 0, 8090
Telemetry [candidate] (8.114 ms) : 0, 8114
IAST [baseline] (28.797 ms) : 0, 28797
IAST [candidate] (31.068 ms) : 0, 31068
section profiling
ProfilingAgent [baseline] (108.483 ms) : 0, 108483
ProfilingAgent [candidate] (107.255 ms) : 0, 107255
crashtracking [baseline] (1.398 ms) : 0, 1398
crashtracking [candidate] (1.403 ms) : 0, 1403
BytebuddyAgent [baseline] (758.531 ms) : 0, 758531
BytebuddyAgent [candidate] (762.707 ms) : 0, 762707
GlobalTracer [baseline] (220.499 ms) : 0, 220499
GlobalTracer [candidate] (221.145 ms) : 0, 221145
AppSec [baseline] (30.158 ms) : 0, 30158
AppSec [candidate] (30.419 ms) : 0, 30419
Debugger [baseline] (6.224 ms) : 0, 6224
Debugger [candidate] (6.254 ms) : 0, 6254
Remote Config [baseline] (677.076 µs) : 0, 677
Remote Config [candidate] (692.003 µs) : 0, 692
Telemetry [baseline] (15.094 ms) : 0, 15094
Telemetry [candidate] (15.906 ms) : 0, 15906
Profiling [baseline] (108.508 ms) : 0, 108508
Profiling [candidate] (107.92 ms) : 0, 107920
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~7283b8f4e8, baseline=1.51.1-SNAPSHOT~b94ca598bb
dateFormat X
axisFormat %s
section baseline
no_agent (4.391 ms) : 4340, 4441
. : milestone, 4391,
iast (9.395 ms) : 9242, 9548
. : milestone, 9395,
iast_FULL (13.643 ms) : 13374, 13912
. : milestone, 13643,
iast_GLOBAL (10.645 ms) : 10458, 10832
. : milestone, 10645,
profiling (8.818 ms) : 8682, 8954
. : milestone, 8818,
tracing (7.446 ms) : 7328, 7563
. : milestone, 7446,
section candidate
no_agent (4.347 ms) : 4299, 4395
. : milestone, 4347,
iast (9.067 ms) : 8922, 9213
. : milestone, 9067,
iast_FULL (13.693 ms) : 13424, 13962
. : milestone, 13693,
iast_GLOBAL (10.096 ms) : 9921, 10272
. : milestone, 10096,
profiling (9.438 ms) : 9298, 9577
. : milestone, 9438,
tracing (7.939 ms) : 7828, 8050
. : milestone, 7939,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~7283b8f4e8, baseline=1.51.1-SNAPSHOT~b94ca598bb
dateFormat X
axisFormat %s
section baseline
no_agent (37.524 ms) : 37218, 37830
. : milestone, 37524,
appsec (48.374 ms) : 47937, 48811
. : milestone, 48374,
code_origins (45.203 ms) : 44811, 45594
. : milestone, 45203,
iast (44.594 ms) : 44215, 44974
. : milestone, 44594,
profiling (49.99 ms) : 49536, 50445
. : milestone, 49990,
tracing (44.959 ms) : 44570, 45349
. : milestone, 44959,
section candidate
no_agent (38.235 ms) : 37925, 38544
. : milestone, 38235,
appsec (46.283 ms) : 45882, 46683
. : milestone, 46283,
code_origins (45.271 ms) : 44883, 45659
. : milestone, 45271,
iast (44.813 ms) : 44424, 45202
. : milestone, 44813,
profiling (48.191 ms) : 47745, 48636
. : milestone, 48191,
tracing (44.413 ms) : 44018, 44807
. : milestone, 44413,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~7283b8f4e8, baseline=1.51.1-SNAPSHOT~b94ca598bb
dateFormat X
axisFormat %s
section baseline
no_agent (15.612 s) : 15612000, 15612000
. : milestone, 15612000,
appsec (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
iast (18.26 s) : 18260000, 18260000
. : milestone, 18260000,
iast_GLOBAL (18.327 s) : 18327000, 18327000
. : milestone, 18327000,
profiling (15.497 s) : 15497000, 15497000
. : milestone, 15497000,
tracing (15.16 s) : 15160000, 15160000
. : milestone, 15160000,
section candidate
no_agent (15.166 s) : 15166000, 15166000
. : milestone, 15166000,
appsec (14.87 s) : 14870000, 14870000
. : milestone, 14870000,
iast (18.526 s) : 18526000, 18526000
. : milestone, 18526000,
iast_GLOBAL (18.081 s) : 18081000, 18081000
. : milestone, 18081000,
profiling (16.008 s) : 16008000, 16008000
. : milestone, 16008000,
tracing (15.165 s) : 15165000, 15165000
. : milestone, 15165000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~7283b8f4e8, baseline=1.51.1-SNAPSHOT~b94ca598bb
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.645 ms) : 3430, 3860
. : milestone, 3645,
iast (2.211 ms) : 2148, 2274
. : milestone, 2211,
iast_GLOBAL (2.243 ms) : 2180, 2305
. : milestone, 2243,
profiling (2.069 ms) : 2017, 2121
. : milestone, 2069,
tracing (2.016 ms) : 1968, 2065
. : milestone, 2016,
section candidate
no_agent (1.478 ms) : 1466, 1490
. : milestone, 1478,
appsec (3.636 ms) : 3420, 3852
. : milestone, 3636,
iast (2.194 ms) : 2132, 2257
. : milestone, 2194,
iast_GLOBAL (2.246 ms) : 2183, 2309
. : milestone, 2246,
profiling (2.047 ms) : 1996, 2097
. : milestone, 2047,
tracing (2.02 ms) : 1971, 2069
. : milestone, 2020,
|
00b6f0b
to
4795008
Compare
...ller-openjdk/src/main/java/com/datadog/profiling/controller/openjdk/JfrProfilerSettings.java
Show resolved
Hide resolved
components/environment/src/main/java/datadog/environment/JvmOptions.java
Outdated
Show resolved
Hide resolved
8652b2a
to
e40af39
Compare
e40af39
to
40186c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...ler-jfr/implementation/src/test/java/com/datadog/profiling/controller/jfr/JFRAccessTest.java
Outdated
Show resolved
Hide resolved
...iling-controller/src/main/java/com/datadog/profiling/controller/ProfilerSettingsSupport.java
Outdated
Show resolved
Hide resolved
...iling-controller/src/main/java/com/datadog/profiling/controller/ProfilerSettingsSupport.java
Outdated
Show resolved
Hide resolved
31f42ec
to
384ba4b
Compare
384ba4b
to
9bd11ec
Compare
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [redis.clients:jedis](https://github.com/redis/jedis) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.0.0` -> `6.1.0` | | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.59.2` -> `2.60.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.2` -> `2.59.0` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.2` -> `2.59.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.68.2` -> `2.69.0` | | [com.squareup.wire](https://github.com/square/wire) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-schema](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-runtime](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-reflector](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-moshi-adapter](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-grpc-client](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-bom](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.51.2` -> `1.52.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:regions](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | --- ### Release Notes <details> <summary>redis/jedis (redis.clients:jedis)</summary> ### [`v6.1.0`](https://github.com/redis/jedis/releases/tag/v6.1.0): 6.1.0 ### Changes #### 🚀 New Features - Add support for SVS-VAMANA vector indexing ([#​4222](redis/jedis#4222)) - Clarify why new stream entries aren't deleted with XDELEX ([#​4218](redis/jedis#4218)) - Add support for new stream commands ([#​4211](redis/jedis#4211)) - Add Support for New BITOP Operations in Redis 8.2 ([#​4188](redis/jedis#4188)) ([#​4190](redis/jedis#4190)) - Add binary stream support for XREAD and XREADGROUP ([#​3566](redis/jedis#3566)) ([#​4152](redis/jedis#4152)) - Run pipeline in current thread if all the keys on same node ([#​4149](redis/jedis#4149)) #### 🐛 Bug Fixes - Restore binary compatibility of SetParams ([#​4225](redis/jedis#4225)) - Fix memory leak in JedisClusterInfoCache - replica nodes not cleared ([#​4205](redis/jedis#4205)) - Fix:JedisCluster throws NullPointerException when maxAttempts is set to 0 ([#​4186](redis/jedis#4186)) #### 🧰 Maintenance - DOC-5471 time series doc examples ([#​4210](redis/jedis#4210)) - Bump jackson.version from 2.19.1 to 2.19.2 ([#​4208](redis/jedis#4208)) - Fix flaky test ClientCommandsTest.killSkipmeYesNo ([#​4206](redis/jedis#4206)) - Bump org.junit:junit-bom from 5.13.2 to 5.13.3 ([#​4198](redis/jedis#4198)) - Migrate publishing to Maven Central Portal ([#​4199](redis/jedis#4199)) - Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.7 to 3.2.8 ([#​4197](redis/jedis#4197)) - Bump org.junit:junit-bom from 5.13.1 to 5.13.2 ([#​4192](redis/jedis#4192)) - DOC-5227 added probabilistic data type examples ([#​4184](redis/jedis#4184)) - Bump jackson.version from 2.19.0 to 2.19.1 ([#​4180](redis/jedis#4180)) - Update test infra to use latest Redis ([#​4179](redis/jedis#4179)) - Bump org.junit:junit-bom from 5.13.0-RC1 to 5.13.1 ([#​4174](redis/jedis#4174)) - Bump org.json:json from [`2025010`](redis/jedis@20250107) to [`2025051`](redis/jedis@20250517) ([#​4171](redis/jedis#4171)) - Bump org.apache.httpcomponents.client5:httpclient5-fluent from 5.4.4 to 5.5 ([#​4170](redis/jedis#4170)) - Fix flaky tests in DocumentTest ([#​3617](redis/jedis#3617)) - Add retryable command execution example ([#​3780](redis/jedis#3780)) - Bump jackson.version from 2.18.3 to 2.19.0 ([#​4160](redis/jedis#4160)) - Bump com.google.code.gson:gson from 2.12.1 to 2.13.1 ([#​4161](redis/jedis#4161)) #### Contributors We'd like to thank all the contributors who worked on this release! [@​219sansim](https://github.com/219sansim), [@​YoHanKi](https://github.com/YoHanKi), [@​andy-stark-redis](https://github.com/andy-stark-redis), [@​ggivo](https://github.com/ggivo), [@​jujn](https://github.com/jujn), [@​thachlp](https://github.com/thachlp), [@​uglide](https://github.com/uglide) and [@​xrayw](https://github.com/xrayw) </details> <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.60.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2600-2025-06-23) ##### Features - handle auto pagination for BigQuery v2 ([#​3829](googleapis/sdk-platform-java#3829)) ([025c84c](googleapis/sdk-platform-java@025c84c)) ##### Dependencies - update google auth library dependencies to v1.37.1 ([#​3846](googleapis/sdk-platform-java#3846)) ([ea1d9e5](googleapis/sdk-platform-java@ea1d9e5)) - update google http client dependencies to v1.47.1 ([#​3848](googleapis/sdk-platform-java#3848)) ([a9a39d7](googleapis/sdk-platform-java@a9a39d7)) </details> <details> <summary>square/wire (com.squareup.wire)</summary> ### [`v5.3.6`](https://github.com/square/wire/blob/HEAD/CHANGELOG.md#Version-536) [Compare Source](square/wire@5.3.5...5.3.6) *2025-08-05* ##### CLI - New CLI option `--ignore_unused_roots_and_prunes` ([#​3354](square/wire#3354)) ##### JVM - Fix: Handle negative hexadecimal in default values ([#​3355](square/wire#3355)) - Optimization: Avoid copying of repeated and map types when mutableTypes are being used ([#​3352](square/wire#3352) by \[Rahul Ravikumar]\[tikurahul]) ##### Swift - Fix: Properly disambiguate OneOf enum if it has the same name as enclosing type ([#​3350](square/wire#3350) by \[Dimitris Koutsogiorgas]\[dnkoutso]) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.52.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.52.0): 1.52.0 ### Components #### Application Security Management (WAF) - ✨ Only report ASM\_DD, ASM\_DATA and ASM capabilities when AppSec is enabled ([#​9260](DataDog/dd-trace-java#9260) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix NPE in AppSecConfigServiceImpl ([#​9165](DataDog/dd-trace-java#9165) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6 ([#​9160](DataDog/dd-trace-java#9160) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Build & Tooling - ✨📖 Automatically register crashtracking via native extensions ([#​8851](DataDog/dd-trace-java#8851) - [@​MattAlp](https://github.com/MattAlp)) #### Configuration at Runtime - ✨ Create activation origin config for telemetry ([#​9064](DataDog/dd-trace-java#9064) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Continuous Integration Visibility - ✨ Update GitLab provided tags ([#​9275](DataDog/dd-trace-java#9275) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Fix base branch SHA usage in GitHub Actions ([#​9257](DataDog/dd-trace-java#9257) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add `ci.job.id` tag ([#​9256](DataDog/dd-trace-java#9256) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add new org to Weaver instrumentation ([#​9235](DataDog/dd-trace-java#9235) - [@​daniel-mohedano](https://github.com/daniel-mohedano) - thanks for the contribution!) - ✨ Improve Git commit info building ([#​9210](DataDog/dd-trace-java#9210) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update Attempt to Fix to v5 ([#​9145](DataDog/dd-trace-java#9145) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Crash tracking - ✨📖 Automatically register crashtracking via native extensions ([#​8851](DataDog/dd-trace-java#8851) - [@​MattAlp](https://github.com/MattAlp)) #### Data Streams Monitoring - ✨ Reduce DSM CPU overheard ([#​9151](DataDog/dd-trace-java#9151) - [@​kr-igor](https://github.com/kr-igor)) - ✨⚡ DSM optimizations for high throughput scenarios ([#​9137](DataDog/dd-trace-java#9137) - [@​kr-igor](https://github.com/kr-igor)) #### Database Monitoring - 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode ([#​9224](DataDog/dd-trace-java#9224) - [@​lu-zhengda](https://github.com/lu-zhengda)) #### Dynamic Instrumentation - 🐛 Add URI in string primitives ([#​9285](DataDog/dd-trace-java#9285) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Increase SourceFile tracking max queue size ([#​9271](DataDog/dd-trace-java#9271) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add capping on SourceFile tracking queue ([#​9245](DataDog/dd-trace-java#9245) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add third-party filtering in SourceFile tracking ([#​9205](DataDog/dd-trace-java#9205) - [@​jpbempel](https://github.com/jpbempel)) #### ML Observability (LLMObs) - ✨ Add methods to capture embedding and retrieval spans ([#​9297](DataDog/dd-trace-java#9297) - [@​nayeem-kamal](https://github.com/nayeem-kamal)) #### Metrics - ✨ Change primary client stats configuration key ([#​9196](DataDog/dd-trace-java#9196) - [@​amarziali](https://github.com/amarziali)) - ✨ Calculate client stats also if the span kind is eligible ([#​9157](DataDog/dd-trace-java#9157) - [@​amarziali](https://github.com/amarziali)) - ✨ Backpropagate peer tags ([#​9144](DataDog/dd-trace-java#9144) - [@​bric3](https://github.com/bric3)) - 🐛 Make client stats reliable in case of downgrade ([#​9136](DataDog/dd-trace-java#9136) - [@​amarziali](https://github.com/amarziali)) #### Platform components - 🐛 Fix VM options parsing from /proc/fs ([#​9255](DataDog/dd-trace-java#9255) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Profiling - ✨ Switch profile compression to zstd default ([#​9293](DataDog/dd-trace-java#9293) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.29.0 ([#​9262](DataDog/dd-trace-java#9262) - [@​zhengyu123](https://github.com/zhengyu123)) - Potential memory leak and race with the JVMTI wallclock sampler by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#234 - Downport async-profiler no-allocation changes by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#245 - Adopt openjdk safefetch by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#246 - Safe fetch 64-bit value and pointer by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#247 - Rebase on Async-Profiler 4.1 by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#252 - Patch upstream stackWalker.cpp not to fail on unaligned access by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#218 - Remap thread id to avoid bitmap contention by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#229 - Improve performance using Unsafe to activate/deactivate thread filter by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#230 - Unify context propagation by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#231 - 🐛 Fix the profiler stackdepth setting propagation in recent (22+) Java versions ([#​9130](DataDog/dd-trace-java#9130) - [@​jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - ✨ Wrap servlet original PrintWriter on rum injector ([#​9146](DataDog/dd-trace-java#9146) - [@​amarziali](https://github.com/amarziali)) #### Telemetry - ✨ Create activation origin config for telemetry ([#​9064](DataDog/dd-trace-java#9064) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Tracer core - ✨⚡ Reduce span construction overhead by switching to optimized TagMap ([#​8589](DataDog/dd-trace-java#8589) - [@​dougqh](https://github.com/dougqh)) - 🐛 Match Hands Off Config selectors on process\_arguments value ([#​9201](DataDog/dd-trace-java#9201) - [@​paullegranddc](https://github.com/paullegranddc)) - ✨ Move JSON generation to sender thread to improve startup time. ([#​9197](DataDog/dd-trace-java#9197) - [@​AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - ✨ Improve agent to avoid loading global config on main thread ([#​9190](DataDog/dd-trace-java#9190) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ add injection metadata fields to telemetry forwarder ([#​9185](DataDog/dd-trace-java#9185) - [@​sydney-tung](https://github.com/sydney-tung)) - 🐛 Avoid race conditions on feature discovery during Writer creation ([#​9173](DataDog/dd-trace-java#9173) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Surface potential root cause when agent initialization errors ([#​9170](DataDog/dd-trace-java#9170) - [@​AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Support adding W3C baggage as span tags ([#​9169](DataDog/dd-trace-java#9169) - [@​rachelyangdog](https://github.com/rachelyangdog)) - ✨⚡ Align our default classloader excludes with OTel ([#​9161](DataDog/dd-trace-java#9161) - [@​mcculls](https://github.com/mcculls)) - ✨ Backpropagate container tags hash coming from the info endpoint ([#​9156](DataDog/dd-trace-java#9156) - [@​amarziali](https://github.com/amarziali)) - 🐛 Avoid race conditions and multiple agent discovery feature states ([#​9135](DataDog/dd-trace-java#9135) - [@​amarziali](https://github.com/amarziali)) ### Instrumentations #### AWS SDK instrumentation - ✨ Enhance Service Representation for Serverless ([#​9203](DataDog/dd-trace-java#9203) - [@​zarirhamza](https://github.com/zarirhamza)) #### gRPC instrumentation - 🐛 Add check to prevent injection of repeated GRPC headers ([#​9246](DataDog/dd-trace-java#9246) - [@​mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode ([#​9224](DataDog/dd-trace-java#9224) - [@​lu-zhengda](https://github.com/lu-zhengda)) #### Play Framework instrumentation - 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6 ([#​9160](DataDog/dd-trace-java#9160) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9da36329ffa552291a640381780b608ef6513e29
What Does This Do
This updates the implementation of the propagation of the stackdepth setting to JFR for JDK 22+
Motivation
In JDK 22 there were some changes in the JFR internal classes we are (mis)using to propagate the stackdepth setting to JFR. Unfortunately, the tests were too lenient and didn't catch the regression.
As a part of the fix, the test was also improved to immediately spot any problem when we run on a newer JDK.
Additional Notes
The patch is also updating the emitted profiler settings events to distinguish between the JFR stackdpeth and the profiler library stackdepth (if present).
I had to update the
JvmOptions
class which failed when used in the GraalVM native smoke tests.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-12093