-
Notifications
You must be signed in to change notification settings - Fork 312
Switched to JUnit 5 Assumptions for consistency. Minor code cleanup. #9126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~5a09a4a521, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (995.137 ms) : 0, 995137
Total [baseline] (8.581 s) : 0, 8580949
Agent [candidate] (1.009 s) : 0, 1009215
Total [candidate] (8.633 s) : 0, 8633474
section iast
Agent [baseline] (1.13 s) : 0, 1129593
Total [baseline] (9.278 s) : 0, 9278139
Agent [candidate] (1.131 s) : 0, 1130940
Total [candidate] (9.306 s) : 0, 9305643
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~5a09a4a521, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.445 ms) : 0, 687445
BytebuddyAgent [candidate] (698.942 ms) : 0, 698942
GlobalTracer [baseline] (241.846 ms) : 0, 241846
GlobalTracer [candidate] (243.593 ms) : 0, 243593
AppSec [baseline] (30.236 ms) : 0, 30236
AppSec [candidate] (30.686 ms) : 0, 30686
Debugger [baseline] (5.963 ms) : 0, 5963
Debugger [candidate] (6.078 ms) : 0, 6078
Remote Config [baseline] (679.315 µs) : 0, 679
Remote Config [candidate] (689.699 µs) : 0, 690
Telemetry [baseline] (8.227 ms) : 0, 8227
Telemetry [candidate] (8.301 ms) : 0, 8301
section iast
BytebuddyAgent [baseline] (805.687 ms) : 0, 805687
BytebuddyAgent [candidate] (807.142 ms) : 0, 807142
GlobalTracer [baseline] (231.714 ms) : 0, 231714
GlobalTracer [candidate] (231.511 ms) : 0, 231511
IAST [baseline] (26.164 ms) : 0, 26164
IAST [candidate] (27.084 ms) : 0, 27084
AppSec [baseline] (31.193 ms) : 0, 31193
AppSec [candidate] (30.214 ms) : 0, 30214
Debugger [baseline] (5.72 ms) : 0, 5720
Debugger [candidate] (5.773 ms) : 0, 5773
Remote Config [baseline] (572.436 µs) : 0, 572
Remote Config [candidate] (577.698 µs) : 0, 578
Telemetry [baseline] (7.918 ms) : 0, 7918
Telemetry [candidate] (7.954 ms) : 0, 7954
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~5a09a4a521, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (997.162 ms) : 0, 997162
Total [baseline] (10.646 s) : 0, 10645822
Agent [candidate] (999.829 ms) : 0, 999829
Total [candidate] (10.637 s) : 0, 10637474
section appsec
Agent [baseline] (1.175 s) : 0, 1174972
Total [baseline] (10.776 s) : 0, 10776145
Agent [candidate] (1.174 s) : 0, 1174335
Total [candidate] (10.79 s) : 0, 10789968
section iast
Agent [baseline] (1.131 s) : 0, 1130890
Total [baseline] (10.836 s) : 0, 10835769
Agent [candidate] (1.148 s) : 0, 1148400
Total [candidate] (10.897 s) : 0, 10897383
section profiling
Agent [baseline] (1.271 s) : 0, 1270973
Total [baseline] (11.074 s) : 0, 11073574
Agent [candidate] (1.244 s) : 0, 1243802
Total [candidate] (11.028 s) : 0, 11027884
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~5a09a4a521, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.45 ms) : 0, 688450
BytebuddyAgent [candidate] (691.273 ms) : 0, 691273
GlobalTracer [baseline] (241.811 ms) : 0, 241811
GlobalTracer [candidate] (242.404 ms) : 0, 242404
AppSec [baseline] (30.342 ms) : 0, 30342
AppSec [candidate] (30.453 ms) : 0, 30453
Debugger [baseline] (5.939 ms) : 0, 5939
Debugger [candidate] (5.957 ms) : 0, 5957
Remote Config [baseline] (688.83 µs) : 0, 689
Remote Config [candidate] (676.521 µs) : 0, 677
Telemetry [baseline] (8.986 ms) : 0, 8986
Telemetry [candidate] (8.173 ms) : 0, 8173
section appsec
BytebuddyAgent [baseline] (710.253 ms) : 0, 710253
BytebuddyAgent [candidate] (710.439 ms) : 0, 710439
GlobalTracer [baseline] (235.207 ms) : 0, 235207
GlobalTracer [candidate] (234.873 ms) : 0, 234873
AppSec [baseline] (171.192 ms) : 0, 171192
AppSec [candidate] (170.654 ms) : 0, 170654
Debugger [baseline] (5.652 ms) : 0, 5652
Debugger [candidate] (5.656 ms) : 0, 5656
Remote Config [baseline] (594.258 µs) : 0, 594
Remote Config [candidate] (592.729 µs) : 0, 593
Telemetry [baseline] (8.002 ms) : 0, 8002
Telemetry [candidate] (8.042 ms) : 0, 8042
IAST [baseline] (23.226 ms) : 0, 23226
IAST [candidate] (23.23 ms) : 0, 23230
section iast
BytebuddyAgent [baseline] (806.553 ms) : 0, 806553
BytebuddyAgent [candidate] (819.747 ms) : 0, 819747
GlobalTracer [baseline] (232.16 ms) : 0, 232160
GlobalTracer [candidate] (235.049 ms) : 0, 235049
AppSec [baseline] (31.218 ms) : 0, 31218
AppSec [candidate] (29.312 ms) : 0, 29312
Debugger [baseline] (5.721 ms) : 0, 5721
Debugger [candidate] (5.838 ms) : 0, 5838
Remote Config [baseline] (584.643 µs) : 0, 585
Remote Config [candidate] (595.707 µs) : 0, 596
Telemetry [baseline] (7.929 ms) : 0, 7929
Telemetry [candidate] (8.064 ms) : 0, 8064
IAST [baseline] (26.05 ms) : 0, 26050
IAST [candidate] (28.151 ms) : 0, 28151
section profiling
ProfilingAgent [baseline] (106.981 ms) : 0, 106981
ProfilingAgent [candidate] (103.938 ms) : 0, 103938
BytebuddyAgent [baseline] (693.198 ms) : 0, 693198
BytebuddyAgent [candidate] (677.96 ms) : 0, 677960
GlobalTracer [baseline] (367.21 ms) : 0, 367210
GlobalTracer [candidate] (361.048 ms) : 0, 361048
AppSec [baseline] (35.28 ms) : 0, 35280
AppSec [candidate] (33.001 ms) : 0, 33001
Debugger [baseline] (8.524 ms) : 0, 8524
Debugger [candidate] (9.809 ms) : 0, 9809
Remote Config [baseline] (676.193 µs) : 0, 676
Remote Config [candidate] (663.083 µs) : 0, 663
Telemetry [baseline] (9.635 ms) : 0, 9635
Telemetry [candidate] (8.77 ms) : 0, 8770
Profiling [baseline] (107.005 ms) : 0, 107005
Profiling [candidate] (103.961 ms) : 0, 103961
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~5a09a4a521, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section baseline
no_agent (37.241 ms) : 36929, 37553
. : milestone, 37241,
appsec (49.661 ms) : 49218, 50104
. : milestone, 49661,
code_origins (45.435 ms) : 45039, 45831
. : milestone, 45435,
iast (44.433 ms) : 44041, 44825
. : milestone, 44433,
profiling (49.832 ms) : 49375, 50289
. : milestone, 49832,
tracing (43.654 ms) : 43288, 44019
. : milestone, 43654,
section candidate
no_agent (36.448 ms) : 36161, 36735
. : milestone, 36448,
appsec (48.874 ms) : 48425, 49323
. : milestone, 48874,
code_origins (43.045 ms) : 42679, 43411
. : milestone, 43045,
iast (45.314 ms) : 44911, 45717
. : milestone, 45314,
profiling (49.751 ms) : 49258, 50243
. : milestone, 49751,
tracing (43.262 ms) : 42904, 43620
. : milestone, 43262,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~5a09a4a521, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section baseline
no_agent (4.283 ms) : 4235, 4332
. : milestone, 4283,
iast (9.288 ms) : 9136, 9440
. : milestone, 9288,
iast_FULL (13.875 ms) : 13603, 14147
. : milestone, 13875,
iast_GLOBAL (10.107 ms) : 9924, 10290
. : milestone, 10107,
profiling (8.585 ms) : 8455, 8716
. : milestone, 8585,
tracing (7.482 ms) : 7377, 7587
. : milestone, 7482,
section candidate
no_agent (4.305 ms) : 4258, 4352
. : milestone, 4305,
iast (9.532 ms) : 9374, 9690
. : milestone, 9532,
iast_FULL (14.036 ms) : 13754, 14319
. : milestone, 14036,
iast_GLOBAL (10.011 ms) : 9836, 10187
. : milestone, 10011,
profiling (8.625 ms) : 8492, 8759
. : milestone, 8625,
tracing (7.677 ms) : 7570, 7784
. : milestone, 7677,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~5a09a4a521, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section baseline
no_agent (15.462 s) : 15462000, 15462000
. : milestone, 15462000,
appsec (14.745 s) : 14745000, 14745000
. : milestone, 14745000,
iast (18.439 s) : 18439000, 18439000
. : milestone, 18439000,
iast_GLOBAL (17.791 s) : 17791000, 17791000
. : milestone, 17791000,
profiling (15.202 s) : 15202000, 15202000
. : milestone, 15202000,
tracing (14.781 s) : 14781000, 14781000
. : milestone, 14781000,
section candidate
no_agent (15.481 s) : 15481000, 15481000
. : milestone, 15481000,
appsec (14.966 s) : 14966000, 14966000
. : milestone, 14966000,
iast (18.513 s) : 18513000, 18513000
. : milestone, 18513000,
iast_GLOBAL (18.017 s) : 18017000, 18017000
. : milestone, 18017000,
profiling (15.133 s) : 15133000, 15133000
. : milestone, 15133000,
tracing (15.058 s) : 15058000, 15058000
. : milestone, 15058000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~5a09a4a521, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.407 ms) : 2357, 2457
. : milestone, 2407,
iast (2.2 ms) : 2138, 2263
. : milestone, 2200,
iast_GLOBAL (2.236 ms) : 2173, 2298
. : milestone, 2236,
profiling (2.509 ms) : 2333, 2685
. : milestone, 2509,
tracing (2.01 ms) : 1962, 2058
. : milestone, 2010,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (2.41 ms) : 2361, 2460
. : milestone, 2410,
iast (2.203 ms) : 2141, 2266
. : milestone, 2203,
iast_GLOBAL (2.24 ms) : 2177, 2303
. : milestone, 2240,
profiling (2.04 ms) : 1990, 2090
. : milestone, 2040,
tracing (2.024 ms) : 1975, 2073
. : milestone, 2024,
|
What Does This Do
Assumptions
for consistency.Motivation
Avoid mixing JUnit 4 and JUnit 5 in the same test — it’s cleaner and safer to stick with one version.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]