-
Notifications
You must be signed in to change notification settings - Fork 312
Fix canceling of running pipelines on new push #9090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~a10ddf7d2f, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.495 ms) : 0, 996495
Total [baseline] (10.616 s) : 0, 10615713
Agent [candidate] (1.004 s) : 0, 1003954
Total [candidate] (10.796 s) : 0, 10795979
section appsec
Agent [baseline] (1.181 s) : 0, 1180720
Total [baseline] (10.747 s) : 0, 10746552
Agent [candidate] (1.185 s) : 0, 1185165
Total [candidate] (10.699 s) : 0, 10699267
section iast
Agent [baseline] (1.131 s) : 0, 1130775
Total [baseline] (10.796 s) : 0, 10796271
Agent [candidate] (1.132 s) : 0, 1132016
Total [candidate] (10.824 s) : 0, 10824143
section profiling
Agent [baseline] (1.246 s) : 0, 1246419
Total [baseline] (11.114 s) : 0, 11113625
Agent [candidate] (1.244 s) : 0, 1243996
Total [candidate] (10.886 s) : 0, 10885685
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~a10ddf7d2f, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.499 ms) : 0, 687499
BytebuddyAgent [candidate] (693.683 ms) : 0, 693683
GlobalTracer [baseline] (242.469 ms) : 0, 242469
GlobalTracer [candidate] (243.87 ms) : 0, 243870
AppSec [baseline] (30.662 ms) : 0, 30662
AppSec [candidate] (30.443 ms) : 0, 30443
Debugger [baseline] (6.097 ms) : 0, 6097
Debugger [candidate] (6.062 ms) : 0, 6062
Remote Config [baseline] (682.185 µs) : 0, 682
Remote Config [candidate] (691.269 µs) : 0, 691
Telemetry [baseline] (8.308 ms) : 0, 8308
Telemetry [candidate] (8.276 ms) : 0, 8276
section appsec
BytebuddyAgent [baseline] (714.932 ms) : 0, 714932
BytebuddyAgent [candidate] (717.542 ms) : 0, 717542
GlobalTracer [baseline] (236.736 ms) : 0, 236736
GlobalTracer [candidate] (237.334 ms) : 0, 237334
AppSec [baseline] (171.405 ms) : 0, 171405
AppSec [candidate] (172.247 ms) : 0, 172247
Debugger [baseline] (5.826 ms) : 0, 5826
Debugger [candidate] (5.872 ms) : 0, 5872
Remote Config [baseline] (615.558 µs) : 0, 616
Remote Config [candidate] (625.407 µs) : 0, 625
Telemetry [baseline] (8.156 ms) : 0, 8156
Telemetry [candidate] (8.209 ms) : 0, 8209
IAST [baseline] (22.294 ms) : 0, 22294
IAST [candidate] (22.367 ms) : 0, 22367
section iast
BytebuddyAgent [baseline] (807.209 ms) : 0, 807209
BytebuddyAgent [candidate] (808.363 ms) : 0, 808363
GlobalTracer [baseline] (233.079 ms) : 0, 233079
GlobalTracer [candidate] (233.408 ms) : 0, 233408
AppSec [baseline] (27.694 ms) : 0, 27694
AppSec [candidate] (28.465 ms) : 0, 28465
Debugger [baseline] (5.835 ms) : 0, 5835
Debugger [candidate] (5.792 ms) : 0, 5792
Remote Config [baseline] (575.225 µs) : 0, 575
Remote Config [candidate] (593.251 µs) : 0, 593
Telemetry [baseline] (7.917 ms) : 0, 7917
Telemetry [candidate] (7.932 ms) : 0, 7932
IAST [baseline] (27.721 ms) : 0, 27721
IAST [candidate] (26.687 ms) : 0, 26687
section profiling
BytebuddyAgent [baseline] (678.059 ms) : 0, 678059
BytebuddyAgent [candidate] (677.637 ms) : 0, 677637
GlobalTracer [baseline] (361.866 ms) : 0, 361866
GlobalTracer [candidate] (361.685 ms) : 0, 361685
AppSec [baseline] (31.046 ms) : 0, 31046
AppSec [candidate] (31.616 ms) : 0, 31616
Debugger [baseline] (11.434 ms) : 0, 11434
Debugger [candidate] (10.555 ms) : 0, 10555
Remote Config [baseline] (665.063 µs) : 0, 665
Remote Config [candidate] (669.957 µs) : 0, 670
Telemetry [baseline] (10.223 ms) : 0, 10223
Telemetry [candidate] (10.243 ms) : 0, 10243
ProfilingAgent [baseline] (104.625 ms) : 0, 104625
ProfilingAgent [candidate] (102.92 ms) : 0, 102920
Profiling [baseline] (104.649 ms) : 0, 104649
Profiling [candidate] (102.944 ms) : 0, 102944
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~a10ddf7d2f, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.006 s) : 0, 1006358
Total [baseline] (8.551 s) : 0, 8550976
Agent [candidate] (1.001 s) : 0, 1000805
Total [candidate] (8.619 s) : 0, 8618584
section iast
Agent [baseline] (1.132 s) : 0, 1131945
Total [baseline] (9.256 s) : 0, 9255518
Agent [candidate] (1.142 s) : 0, 1141503
Total [candidate] (9.286 s) : 0, 9285844
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~a10ddf7d2f, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.265 ms) : 0, 695265
BytebuddyAgent [candidate] (691.163 ms) : 0, 691163
GlobalTracer [baseline] (244.099 ms) : 0, 244099
GlobalTracer [candidate] (243.23 ms) : 0, 243230
AppSec [baseline] (30.831 ms) : 0, 30831
AppSec [candidate] (30.611 ms) : 0, 30611
Debugger [baseline] (6.146 ms) : 0, 6146
Debugger [candidate] (6.043 ms) : 0, 6043
Remote Config [baseline] (679.415 µs) : 0, 679
Remote Config [candidate] (688.652 µs) : 0, 689
Telemetry [baseline] (8.322 ms) : 0, 8322
Telemetry [candidate] (8.303 ms) : 0, 8303
section iast
BytebuddyAgent [baseline] (807.953 ms) : 0, 807953
BytebuddyAgent [candidate] (814.708 ms) : 0, 814708
GlobalTracer [baseline] (232.692 ms) : 0, 232692
GlobalTracer [candidate] (234.854 ms) : 0, 234854
AppSec [baseline] (28.609 ms) : 0, 28609
AppSec [candidate] (27.25 ms) : 0, 27250
Debugger [baseline] (5.866 ms) : 0, 5866
Debugger [candidate] (5.909 ms) : 0, 5909
Remote Config [baseline] (604.027 µs) : 0, 604
Remote Config [candidate] (610.583 µs) : 0, 611
Telemetry [baseline] (8.838 ms) : 0, 8838
Telemetry [candidate] (8.107 ms) : 0, 8107
IAST [baseline] (26.529 ms) : 0, 26529
IAST [candidate] (29.102 ms) : 0, 29102
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~a10ddf7d2f, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section baseline
no_agent (4.596 ms) : 4540, 4652
. : milestone, 4596,
iast (9.619 ms) : 9459, 9779
. : milestone, 9619,
iast_FULL (14.876 ms) : 14577, 15175
. : milestone, 14876,
iast_GLOBAL (10.566 ms) : 10361, 10771
. : milestone, 10566,
profiling (9.375 ms) : 9228, 9522
. : milestone, 9375,
tracing (8.023 ms) : 7907, 8138
. : milestone, 8023,
section candidate
no_agent (4.702 ms) : 4639, 4764
. : milestone, 4702,
iast (9.54 ms) : 9381, 9699
. : milestone, 9540,
iast_FULL (14.331 ms) : 14041, 14622
. : milestone, 14331,
iast_GLOBAL (10.648 ms) : 10459, 10837
. : milestone, 10648,
profiling (9.347 ms) : 9190, 9505
. : milestone, 9347,
tracing (7.863 ms) : 7751, 7974
. : milestone, 7863,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~a10ddf7d2f, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section baseline
no_agent (37.98 ms) : 37673, 38286
. : milestone, 37980,
appsec (48.984 ms) : 48548, 49420
. : milestone, 48984,
code_origins (47.733 ms) : 47325, 48140
. : milestone, 47733,
iast (45.795 ms) : 45400, 46189
. : milestone, 45795,
profiling (47.402 ms) : 46978, 47826
. : milestone, 47402,
tracing (44.756 ms) : 44368, 45143
. : milestone, 44756,
section candidate
no_agent (39.525 ms) : 39205, 39845
. : milestone, 39525,
appsec (49.474 ms) : 49053, 49895
. : milestone, 49474,
code_origins (46.309 ms) : 45901, 46718
. : milestone, 46309,
iast (45.59 ms) : 45198, 45983
. : milestone, 45590,
profiling (51.34 ms) : 50880, 51800
. : milestone, 51340,
tracing (46.319 ms) : 45932, 46707
. : milestone, 46319,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~a10ddf7d2f, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.403 ms) : 2354, 2452
. : milestone, 2403,
iast (2.19 ms) : 2128, 2252
. : milestone, 2190,
iast_GLOBAL (2.23 ms) : 2167, 2293
. : milestone, 2230,
profiling (2.031 ms) : 1981, 2080
. : milestone, 2031,
tracing (2.014 ms) : 1965, 2062
. : milestone, 2014,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.402 ms) : 2352, 2451
. : milestone, 2402,
iast (2.189 ms) : 2126, 2251
. : milestone, 2189,
iast_GLOBAL (2.229 ms) : 2166, 2291
. : milestone, 2229,
profiling (2.036 ms) : 1986, 2086
. : milestone, 2036,
tracing (2.005 ms) : 1957, 2053
. : milestone, 2005,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~a10ddf7d2f, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section baseline
no_agent (15.75 s) : 15750000, 15750000
. : milestone, 15750000,
appsec (14.658 s) : 14658000, 14658000
. : milestone, 14658000,
iast (18.672 s) : 18672000, 18672000
. : milestone, 18672000,
iast_GLOBAL (17.992 s) : 17992000, 17992000
. : milestone, 17992000,
profiling (15.332 s) : 15332000, 15332000
. : milestone, 15332000,
tracing (14.809 s) : 14809000, 14809000
. : milestone, 14809000,
section candidate
no_agent (14.967 s) : 14967000, 14967000
. : milestone, 14967000,
appsec (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
iast (18.651 s) : 18651000, 18651000
. : milestone, 18651000,
iast_GLOBAL (18.258 s) : 18258000, 18258000
. : milestone, 18258000,
profiling (16.033 s) : 16033000, 16033000
. : milestone, 16033000,
tracing (14.694 s) : 14694000, 14694000
. : milestone, 14694000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! This clearly shows my limit in GitLab knowledge 😓
What Does This Do
Enables the behavior introduced by #9023 . #9023 added a second
default:
block which was shadowed by thedefault
block later in the file. As a result, only jobs which explicitly declared themselvesinterruptible
were actually canceled. For this repo, that limited the cancels to the benchmark jobs.This PR fixes the issue by combining the default blocks.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issue