Fixing bug with dropping baggage when `TracePropagationBehaviorExtract=IGNORE` #9037

mhlidd · 2025-06-25T20:24:32Z

What Does This Do

Previously, baggage was not being dropped when TracePropagationBehaviorExtract=IGNORE. This PR fixes that bug and addresses failures in APMAPI-1443.

Also fixes bug in call to base BaggagePropagator constructor.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-1443

…act = IGNORE

pr-commenter · 2025-06-25T20:55:30Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/tracecontext_propagation_style_ignore
git_commit_date	1750947167	1750951778
git_commit_sha	`928d44f`	`a26badd`
release_version	1.51.0-SNAPSHOT~928d44f35c	1.51.0-SNAPSHOT~a26badd44a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1750953640	1750953640
ci_job_id	1000586363	1000586363
ci_pipeline_id	68880669	68880669
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-iun2vzqu-project-304-concurrent-0-52z3wlfw 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-iun2vzqu-project-304-concurrent-0-52z3wlfw 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~a26badd44a, baseline=1.51.0-SNAPSHOT~928d44f35c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.005 s) : 0, 1005316
Total [baseline] (8.576 s) : 0, 8575555
Agent [candidate] (996.413 ms) : 0, 996413
Total [candidate] (8.582 s) : 0, 8582315
section iast
Agent [baseline] (1.14 s) : 0, 1139901
Total [baseline] (9.273 s) : 0, 9272921
Agent [candidate] (1.139 s) : 0, 1138764
Total [candidate] (9.281 s) : 0, 9280576

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.005 s	-
Agent	iast	1.14 s	134.585 ms (13.4%)
Total	tracing	8.576 s	-
Total	iast	9.273 s	697.366 ms (8.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	996.413 ms	-
Agent	iast	1.139 s	142.352 ms (14.3%)
Total	tracing	8.582 s	-
Total	iast	9.281 s	698.261 ms (8.1%)

gantt
    title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~a26badd44a, baseline=1.51.0-SNAPSHOT~928d44f35c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.487 ms) : 0, 694487
BytebuddyAgent [candidate] (687.593 ms) : 0, 687593
GlobalTracer [baseline] (243.982 ms) : 0, 243982
GlobalTracer [candidate] (242.716 ms) : 0, 242716
AppSec [baseline] (30.769 ms) : 0, 30769
AppSec [candidate] (30.335 ms) : 0, 30335
Debugger [baseline] (6.092 ms) : 0, 6092
Debugger [candidate] (6.038 ms) : 0, 6038
Remote Config [baseline] (675.975 µs) : 0, 676
Remote Config [candidate] (666.266 µs) : 0, 666
Telemetry [baseline] (8.301 ms) : 0, 8301
Telemetry [candidate] (8.212 ms) : 0, 8212
section iast
BytebuddyAgent [baseline] (813.66 ms) : 0, 813660
BytebuddyAgent [candidate] (814.322 ms) : 0, 814322
GlobalTracer [baseline] (234.719 ms) : 0, 234719
GlobalTracer [candidate] (233.634 ms) : 0, 233634
IAST [baseline] (25.735 ms) : 0, 25735
IAST [candidate] (29.662 ms) : 0, 29662
AppSec [baseline] (30.318 ms) : 0, 30318
AppSec [candidate] (26.058 ms) : 0, 26058
Debugger [baseline] (5.889 ms) : 0, 5889
Debugger [candidate] (5.781 ms) : 0, 5781
Remote Config [baseline] (586.724 µs) : 0, 587
Remote Config [candidate] (574.341 µs) : 0, 574
Telemetry [baseline] (8.126 ms) : 0, 8126
Telemetry [candidate] (7.917 ms) : 0, 7917

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~a26badd44a, baseline=1.51.0-SNAPSHOT~928d44f35c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (997.198 ms) : 0, 997198
Total [baseline] (10.662 s) : 0, 10661974
Agent [candidate] (997.106 ms) : 0, 997106
Total [candidate] (10.643 s) : 0, 10643074
section appsec
Agent [baseline] (1.173 s) : 0, 1172977
Total [baseline] (10.719 s) : 0, 10719135
Agent [candidate] (1.18 s) : 0, 1179531
Total [candidate] (10.729 s) : 0, 10729299
section iast
Agent [baseline] (1.139 s) : 0, 1139479
Total [baseline] (10.832 s) : 0, 10831768
Agent [candidate] (1.133 s) : 0, 1133071
Total [candidate] (10.802 s) : 0, 10801989
section profiling
Agent [baseline] (1.253 s) : 0, 1252843
Total [baseline] (11.027 s) : 0, 11026857
Agent [candidate] (1.244 s) : 0, 1243788
Total [candidate] (10.883 s) : 0, 10882520

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	997.198 ms	-
Agent	appsec	1.173 s	175.779 ms (17.6%)
Agent	iast	1.139 s	142.28 ms (14.3%)
Agent	profiling	1.253 s	255.644 ms (25.6%)
Total	tracing	10.662 s	-
Total	appsec	10.719 s	57.161 ms (0.5%)
Total	iast	10.832 s	169.793 ms (1.6%)
Total	profiling	11.027 s	364.883 ms (3.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	997.106 ms	-
Agent	appsec	1.18 s	182.425 ms (18.3%)
Agent	iast	1.133 s	135.965 ms (13.6%)
Agent	profiling	1.244 s	246.682 ms (24.7%)
Total	tracing	10.643 s	-
Total	appsec	10.729 s	86.225 ms (0.8%)
Total	iast	10.802 s	158.915 ms (1.5%)
Total	profiling	10.883 s	239.446 ms (2.2%)

gantt
    title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~a26badd44a, baseline=1.51.0-SNAPSHOT~928d44f35c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.119 ms) : 0, 688119
BytebuddyAgent [candidate] (687.687 ms) : 0, 687687
GlobalTracer [baseline] (242.772 ms) : 0, 242772
GlobalTracer [candidate] (242.991 ms) : 0, 242991
AppSec [baseline] (30.431 ms) : 0, 30431
AppSec [candidate] (30.609 ms) : 0, 30609
Debugger [baseline] (6.047 ms) : 0, 6047
Debugger [candidate] (6.102 ms) : 0, 6102
Remote Config [baseline] (687.042 µs) : 0, 687
Remote Config [candidate] (663.89 µs) : 0, 664
Telemetry [baseline] (8.226 ms) : 0, 8226
Telemetry [candidate] (8.211 ms) : 0, 8211
section appsec
BytebuddyAgent [baseline] (709.847 ms) : 0, 709847
BytebuddyAgent [candidate] (715.689 ms) : 0, 715689
GlobalTracer [baseline] (235.476 ms) : 0, 235476
GlobalTracer [candidate] (236.266 ms) : 0, 236266
IAST [baseline] (22.009 ms) : 0, 22009
IAST [candidate] (22.002 ms) : 0, 22002
AppSec [baseline] (170.352 ms) : 0, 170352
AppSec [candidate] (170.268 ms) : 0, 170268
Debugger [baseline] (5.79 ms) : 0, 5790
Debugger [candidate] (5.783 ms) : 0, 5783
Remote Config [baseline] (607.963 µs) : 0, 608
Remote Config [candidate] (626.484 µs) : 0, 626
Telemetry [baseline] (8.139 ms) : 0, 8139
Telemetry [candidate] (8.047 ms) : 0, 8047
section iast
BytebuddyAgent [baseline] (814.101 ms) : 0, 814101
BytebuddyAgent [candidate] (808.807 ms) : 0, 808807
GlobalTracer [baseline] (234.139 ms) : 0, 234139
GlobalTracer [candidate] (233.754 ms) : 0, 233754
IAST [baseline] (28.088 ms) : 0, 28088
IAST [candidate] (27.026 ms) : 0, 27026
AppSec [baseline] (27.893 ms) : 0, 27893
AppSec [candidate] (28.432 ms) : 0, 28432
Debugger [baseline] (5.815 ms) : 0, 5815
Debugger [candidate] (5.798 ms) : 0, 5798
Remote Config [baseline] (575.66 µs) : 0, 576
Remote Config [candidate] (580.061 µs) : 0, 580
Telemetry [baseline] (7.948 ms) : 0, 7948
Telemetry [candidate] (7.899 ms) : 0, 7899
section profiling
BytebuddyAgent [baseline] (683.321 ms) : 0, 683321
BytebuddyAgent [candidate] (678.217 ms) : 0, 678217
GlobalTracer [baseline] (363.129 ms) : 0, 363129
GlobalTracer [candidate] (361.281 ms) : 0, 361281
AppSec [baseline] (31.738 ms) : 0, 31738
AppSec [candidate] (32.378 ms) : 0, 32378
Debugger [baseline] (12.741 ms) : 0, 12741
Debugger [candidate] (11.116 ms) : 0, 11116
Remote Config [baseline] (656.734 µs) : 0, 657
Remote Config [candidate] (662.91 µs) : 0, 663
Telemetry [baseline] (8.022 ms) : 0, 8022
Telemetry [candidate] (8.908 ms) : 0, 8908
ProfilingAgent [baseline] (104.242 ms) : 0, 104242
ProfilingAgent [candidate] (102.531 ms) : 0, 102531
Profiling [baseline] (104.266 ms) : 0, 104266
Profiling [candidate] (102.556 ms) : 0, 102556

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/tracecontext_propagation_style_ignore
git_commit_date	1750947167	1750951778
git_commit_sha	`928d44f`	`a26badd`
release_version	1.51.0-SNAPSHOT~928d44f35c	1.51.0-SNAPSHOT~a26badd44a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1750953324	1750953324
ci_job_id	1000586365	1000586365
ci_pipeline_id	68880669	68880669
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-cpksuxk1-project-304-concurrent-0-co2u5wo5 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-cpksuxk1-project-304-concurrent-0-co2u5wo5 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:appsec:high_load	better [-2.584ms; -1.654ms] or [-5.217%; -3.340%]	unstable [-3.796op/s; +9.827op/s] or [-3.965%; +10.265%]	47.402ms	98.750op/s	49.521ms	95.734op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~a26badd44a, baseline=1.51.0-SNAPSHOT~928d44f35c
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.259 ms) : 4212, 4306
.   : milestone, 4259,
iast (9.211 ms) : 9053, 9368
.   : milestone, 9211,
iast_FULL (13.748 ms) : 13471, 14025
.   : milestone, 13748,
iast_GLOBAL (10.122 ms) : 9944, 10301
.   : milestone, 10122,
profiling (8.951 ms) : 8810, 9091
.   : milestone, 8951,
tracing (7.744 ms) : 7634, 7855
.   : milestone, 7744,
section candidate
no_agent (4.222 ms) : 4174, 4270
.   : milestone, 4222,
iast (9.143 ms) : 8992, 9294
.   : milestone, 9143,
iast_FULL (13.785 ms) : 13520, 14051
.   : milestone, 13785,
iast_GLOBAL (10.15 ms) : 9974, 10327
.   : milestone, 10150,
profiling (8.955 ms) : 8802, 9108
.   : milestone, 8955,
tracing (7.582 ms) : 7469, 7694
.   : milestone, 7582,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.259 ms [4.212 ms, 4.306 ms]	-
iast	9.211 ms [9.053 ms, 9.368 ms]	4.952 ms (116.3%)
iast_FULL	13.748 ms [13.471 ms, 14.025 ms]	9.489 ms (222.8%)
iast_GLOBAL	10.122 ms [9.944 ms, 10.301 ms]	5.864 ms (137.7%)
profiling	8.951 ms [8.81 ms, 9.091 ms]	4.692 ms (110.2%)
tracing	7.744 ms [7.634 ms, 7.855 ms]	3.485 ms (81.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.222 ms [4.174 ms, 4.27 ms]	-
iast	9.143 ms [8.992 ms, 9.294 ms]	4.921 ms (116.6%)
iast_FULL	13.785 ms [13.52 ms, 14.051 ms]	9.564 ms (226.5%)
iast_GLOBAL	10.15 ms [9.974 ms, 10.327 ms]	5.929 ms (140.4%)
profiling	8.955 ms [8.802 ms, 9.108 ms]	4.733 ms (112.1%)
tracing	7.582 ms [7.469 ms, 7.694 ms]	3.36 ms (79.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~a26badd44a, baseline=1.51.0-SNAPSHOT~928d44f35c
    dateFormat X
    axisFormat %s
section baseline
no_agent (35.993 ms) : 35703, 36283
.   : milestone, 35993,
appsec (49.521 ms) : 49077, 49964
.   : milestone, 49521,
code_origins (45.425 ms) : 45013, 45837
.   : milestone, 45425,
iast (43.722 ms) : 43344, 44100
.   : milestone, 43722,
profiling (50.575 ms) : 50104, 51047
.   : milestone, 50575,
tracing (44.718 ms) : 44333, 45104
.   : milestone, 44718,
section candidate
no_agent (36.587 ms) : 36292, 36881
.   : milestone, 36587,
appsec (47.402 ms) : 46982, 47822
.   : milestone, 47402,
code_origins (46.503 ms) : 46114, 46892
.   : milestone, 46503,
iast (42.499 ms) : 42137, 42860
.   : milestone, 42499,
profiling (49.124 ms) : 48689, 49559
.   : milestone, 49124,
tracing (43.999 ms) : 43621, 44376
.   : milestone, 43999,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	35.993 ms [35.703 ms, 36.283 ms]	-
appsec	49.521 ms [49.077 ms, 49.964 ms]	13.528 ms (37.6%)
code_origins	45.425 ms [45.013 ms, 45.837 ms]	9.432 ms (26.2%)
iast	43.722 ms [43.344 ms, 44.1 ms]	7.729 ms (21.5%)
profiling	50.575 ms [50.104 ms, 51.047 ms]	14.583 ms (40.5%)
tracing	44.718 ms [44.333 ms, 45.104 ms]	8.726 ms (24.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.587 ms [36.292 ms, 36.881 ms]	-
appsec	47.402 ms [46.982 ms, 47.822 ms]	10.815 ms (29.6%)
code_origins	46.503 ms [46.114 ms, 46.892 ms]	9.916 ms (27.1%)
iast	42.499 ms [42.137 ms, 42.86 ms]	5.912 ms (16.2%)
profiling	49.124 ms [48.689 ms, 49.559 ms]	12.537 ms (34.3%)
tracing	43.999 ms [43.621 ms, 44.376 ms]	7.412 ms (20.3%)

Dacapo

dd-trace-core/src/main/java/datadog/trace/core/baggage/BaggagePropagator.java

…aggagePropagator

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://github.com/google/error-prone)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.39.0` -> `2.40.0` | | [org.apache.commons:commons-lang3](https://commons.apache.org/proper/commons-lang/) ([source](https://gitbox.apache.org/repos/asf/commons-lang.git)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.17.0` -> `3.18.0` | | [org.jetbrains.kotlinx.binary-compatibility-validator](https://github.com/Kotlin/binary-compatibility-validator) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `0.18.0` -> `0.18.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.50.1` -> `1.51.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | --- ### Release Notes <details> <summary>google/error-prone (com.google.errorprone:error_prone_annotations)</summary> ### [`v2.40.0`](https://github.com/google/error-prone/releases/tag/v2.40.0): Error Prone 2.40.0 Changes: - Bug fixes and improvements - Releases (including snapshots) have migrated from [OSSRH to the Central Publisher Portal](https://central.sonatype.org/pages/ossrh-eol/#process-to-migrate) Full changelog: google/error-prone@v2.39.0...v2.40.0 </details> <details> <summary>Kotlin/binary-compatibility-validator (org.jetbrains.kotlinx.binary-compatibility-validator)</summary> ### [`v0.18.1`](https://github.com/Kotlin/binary-compatibility-validator/releases/tag/0.18.1) [Compare Source](Kotlin/binary-compatibility-validator@0.18.0...0.18.1) #### What's Changed - Fixed a bug preventing use of cross-compilation support during KLIB dump validation \[[#304](https://github.com/Kotlin/binary-compatibility-validator/issues/304)]\[[#306](https://github.com/Kotlin/binary-compatibility-validator/issues/306)] </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.51.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.51.0): 1.51.0 ### Components #### Application Security Management (IAST) - 🐛 Fix verify error when ctor params are used after a call site ([#9083](DataDog/dd-trace-java#9083) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Limit the maximum size of the location path in IAST vulnerabilities ([#9028](DataDog/dd-trace-java#9028) - [@jandro996](https://github.com/jandro996)) - 🐛 Fix IAST gRPC handler with null superclass ([#8984](DataDog/dd-trace-java#8984) - [@smola](https://github.com/smola)) - ✨ Optimize IAST Vulnerability Detection ([#8885](DataDog/dd-trace-java#8885) - [@jandro996](https://github.com/jandro996)) #### Application Security Management (WAF) - ✨ Upgrade libddwaf-java to 15.0.0 ([#9022](DataDog/dd-trace-java#9022) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Extract RestEasy json body response schemas ([#9015](DataDog/dd-trace-java#9015) - [@jandro996](https://github.com/jandro996)) - ✨ Extract Jersey json body response schemas ([#9014](DataDog/dd-trace-java#9014) - [@jandro996](https://github.com/jandro996)) - ✨ Extract Ratpack json body response schemas ([#9013](DataDog/dd-trace-java#9013) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Enable API Security by default and make it lazy loading ([#9009](DataDog/dd-trace-java#9009) - [@smola](https://github.com/smola)) - ✨ Extract Vert.x json body response schemas ([#9001](DataDog/dd-trace-java#9001) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Extract Play json body response schemas ([#8995](DataDog/dd-trace-java#8995) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix Jackson nodes introspection for request/response schema extraction ([#8980](DataDog/dd-trace-java#8980) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Extract Spring json body response schemas ([#8938](DataDog/dd-trace-java#8938) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Default obfuscation regexp update ([#8937](DataDog/dd-trace-java#8937) - [@sezen-datadog](https://github.com/sezen-datadog)) #### Build & Tooling - ✨ Cancel GitLab running pipeline on new PR push ([#9023](DataDog/dd-trace-java#9023) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Migrate publishing to Maven Central Portal ([#8807](DataDog/dd-trace-java#8807) - [@sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - 🐛 Fix Test Optimization to work with JDK 24 ([#9114](DataDog/dd-trace-java#9114) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add repo root as safe directory on git client creation ([#9033](DataDog/dd-trace-java#9033) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add PR number tag and improve PR information building ([#8990](DataDog/dd-trace-java#8990) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update impacted tests logic ([#8923](DataDog/dd-trace-java#8923) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 🧹 Clean up DSM context injection ([#8776](DataDog/dd-trace-java#8776) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Database Monitoring - 🐛 Set trace\_injected in try block ([#9025](DataDog/dd-trace-java#9025) - [@natashadada](https://github.com/natashadada)) #### Dynamic Instrumentation - 🐛 Add source file tracking enable option ([#9115](DataDog/dd-trace-java#9115) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add java.util.Date support ([#9111](DataDog/dd-trace-java#9111) - [@jpbempel](https://github.com/jpbempel)) - ✨ Update file probe format ([#9047](DataDog/dd-trace-java#9047) - [@jpbempel](https://github.com/jpbempel)) - ✨ add safe local var hoisting ([#9034](DataDog/dd-trace-java#9034) - [@jpbempel](https://github.com/jpbempel)) - 🧹 Add new config for debugger upload interval ([#8959](DataDog/dd-trace-java#8959) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enable Code Origin with Dynamic instrumentation ([#8940](DataDog/dd-trace-java#8940) - [@jpbempel](https://github.com/jpbempel)) #### ML Observability (LLMObs) - 💡 LLM Observability SDK ([#8781](DataDog/dd-trace-java#8781) - [@gary-huang](https://github.com/gary-huang), [@nayeem-kamal](https://github.com/nayeem-kamal)) #### Metrics - 🐛 Ensure client stat reporter is started when the agent is not available at bootstrap ([#9082](DataDog/dd-trace-java#9082) - [@amarziali](https://github.com/amarziali)) - ✨ Create metric: appsec.waf.config\_errors ([#8394](DataDog/dd-trace-java#8394) - [@sezen-datadog](https://github.com/sezen-datadog)) #### Platform components - ✨ Introduce environment component ([#9071](DataDog/dd-trace-java#9071) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Profiling - 🐛 Remove annoying warning for smap event parsing ([#9119](DataDog/dd-trace-java#9119) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Fix ByteCountingInputStream when reading past EOF ([#8988](DataDog/dd-trace-java#8988) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Realtime User Monitoring - ✨ Add RUM SDK injection for servlet based web servers ([#9110](DataDog/dd-trace-java#9110) - [@PerfectSlayer](https://github.com/PerfectSlayer) [@amarziali](https://github.com/amarziali)) #### Telemetry - ✨ Update the config origin metric to match what it's mapping ([#9045](DataDog/dd-trace-java#9045) - [@sezen-datadog](https://github.com/sezen-datadog)) #### Testing - ✨ Add testing for latest stable version (JDK 24) ([#8875](DataDog/dd-trace-java#8875) - [@sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - 🐛 Fix bug with dropping baggage when `TracePropagationBehaviorExtract=IGNORE` ([#9037](DataDog/dd-trace-java#9037) - [@mhlidd](https://github.com/mhlidd)) - 🐛 Fix ArrayIndexOutOfBoundsException in PercentEscaper ([#9032](DataDog/dd-trace-java#9032) - [@mhlidd](https://github.com/mhlidd)) #### Tracer core - 🐛 Fix `Error` handling for trace interceptors ([#9097](DataDog/dd-trace-java#9097) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add wildcard feature for `DD_TRACE_HEADER_TAGS` and enabling for Http Response headers ([#9067](DataDog/dd-trace-java#9067) - [@mhlidd](https://github.com/mhlidd)) #### Tracer public API - 💡 Add LLM Observability SDK ([#8781](DataDog/dd-trace-java#8781) - [@gary-huang](https://github.com/gary-huang)) ### Instrumentations #### Akka instrumentation - 🐛 Fix NPE in akka-http and pekko-http integrations ([#9019](DataDog/dd-trace-java#9019) - [@mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - ✨ Extract Vert.x json body response schemas ([#9001](DataDog/dd-trace-java#9001) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Write http.route tag as soon as possible in vert.x ([#8952](DataDog/dd-trace-java#8952) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### JAX-WS instrumentation - 💡⚠️ Enable jax-ws integration by default ([#9030](DataDog/dd-trace-java#9030) - [@bm1549](https://github.com/bm1549)) - ✨ Extract Jersey json body response schemas ([#9014](DataDog/dd-trace-java#9014) - [@jandro996](https://github.com/jandro996)) #### Mule instrumentation - 🐛 Propagate grizzly http span in filters if nothing is active ([#9016](DataDog/dd-trace-java#9016) - [@amarziali](https://github.com/amarziali)) #### Play Framework instrumentation - ✨ Extract Play json body response schemas ([#8995](DataDog/dd-trace-java#8995) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Ratpack instrumentation - ✨ Extract Ratpack json body response schemas ([#9013](DataDog/dd-trace-java#9013) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Spring instrumentation - ✨ Extract Spring json body response schemas ([#8938](DataDog/dd-trace-java#8938) - [@sezen-datadog](https://github.com/sezen-datadog)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 649b690d4c9d7dcb572c457f0802b42b8e3e682e

Fixing issues with dropping baggage when TracePropagationBehaviorExtr…

5facbfd

…act = IGNORE

mhlidd added type: bug Bug report and fix comp: context propagation Trace context propagation labels Jun 25, 2025

mhlidd changed the title ~~Fixing bug with dropping baggage when TracePropagationBehaviorExtract = IGNORE~~ Fixing bug with dropping baggage when TracePropagationBehaviorExtract=IGNORE Jun 25, 2025

updating calls to BaggagePropagator from unit tests

917c6c0

PerfectSlayer requested changes Jun 26, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/baggage/BaggagePropagator.java Outdated Show resolved Hide resolved

fixing call to base constructor

0be2fc1

mhlidd marked this pull request as ready for review June 26, 2025 13:55

mhlidd requested a review from a team as a code owner June 26, 2025 13:55

mhlidd requested review from ygree and PerfectSlayer June 26, 2025 13:55

updating to handle behaviorExtract=IGNORE in CoreTracer rather than B…

a26badd

…aggagePropagator

PerfectSlayer approved these changes Jun 27, 2025

View reviewed changes

mhlidd merged commit 640fc88 into master Jun 27, 2025
508 checks passed

mhlidd deleted the mhlidd/tracecontext_propagation_style_ignore branch June 27, 2025 14:16

github-actions bot added this to the 1.51.0 milestone Jun 27, 2025

This was referenced Jun 27, 2025

🍒 9037 - Fixing bug with dropping baggage when TracePropagationBehaviorExtract=IGNORE #9051

Closed

🍒 9037 - Drop Baggage when TracePropagationBehaviorExtract=IGNORE #9052

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixing bug with dropping baggage when `TracePropagationBehaviorExtract=IGNORE` #9037

Fixing bug with dropping baggage when `TracePropagationBehaviorExtract=IGNORE` #9037

Uh oh!

mhlidd commented Jun 25, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Jun 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fixing bug with dropping baggage when TracePropagationBehaviorExtract=IGNORE #9037

Fixing bug with dropping baggage when TracePropagationBehaviorExtract=IGNORE #9037

Uh oh!

Conversation

mhlidd commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fixing bug with dropping baggage when `TracePropagationBehaviorExtract=IGNORE` #9037

Fixing bug with dropping baggage when `TracePropagationBehaviorExtract=IGNORE` #9037

mhlidd commented Jun 25, 2025 •

edited

Loading

pr-commenter bot commented Jun 25, 2025 •

edited

Loading