Skip to content

Add new config for debugger upload interval #8959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

Add new config for debugger upload interval #8959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/sink/DebuggerSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ public void start() {
} else {
currentLowRateFlushInterval = uploadFlushInterval;
}
LOGGER.debug("Scheduling low rate debugger sink flush to {}ms", currentLowRateFlushInterval);
lowRateScheduled =
lowRateScheduler.scheduleAtFixedRate(
this::lowRateFlush, this, 0, currentLowRateFlushInterval, TimeUnit.MILLISECONDS);
Expand Down
2 changes: 2 additions & 0 deletions dd-trace-api/src/main/java/datadog/trace/api/config/DebuggerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ public final class DebuggerConfig {
"dynamic.instrumentation.upload.timeout";
public static final String DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL =
"dynamic.instrumentation.upload.flush.interval";
public static final String DYNAMIC_INSTRUMENTATION_UPLOAD_INTERVAL_SECONDS =
"dynamic.instrumentation.upload.interval.seconds";
public static final String DYNAMIC_INSTRUMENTATION_UPLOAD_BATCH_SIZE =
"dynamic.instrumentation.upload.batch.size";
public static final String DYNAMIC_INSTRUMENTATION_MAX_PAYLOAD_SIZE =
Expand Down
17 changes: 13 additions & 4 deletions internal-api/src/main/java/datadog/trace/api/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1678,10 +1678,19 @@ PROFILING_DATADOG_PROFILER_ENABLED, isDatadogProfilerSafeInCurrentEnvironment())
dynamicInstrumentationUploadTimeout =
configProvider.getInteger(
DYNAMIC_INSTRUMENTATION_UPLOAD_TIMEOUT, DEFAULT_DYNAMIC_INSTRUMENTATION_UPLOAD_TIMEOUT);
dynamicInstrumentationUploadFlushInterval =
configProvider.getInteger(
DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL,
DEFAULT_DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL);
if (configProvider.isSet(DYNAMIC_INSTRUMENTATION_UPLOAD_INTERVAL_SECONDS)) {
dynamicInstrumentationUploadFlushInterval =
(int)
(configProvider.getFloat(
DYNAMIC_INSTRUMENTATION_UPLOAD_INTERVAL_SECONDS,
DEFAULT_DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL)
* 1000);
} else {
dynamicInstrumentationUploadFlushInterval =
configProvider.getInteger(
DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL,
DEFAULT_DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL);
}
dynamicInstrumentationClassFileDumpEnabled =
configProvider.getBoolean(
DYNAMIC_INSTRUMENTATION_CLASSFILE_DUMP_ENABLED,
Expand Down
5 changes: 3 additions & 2 deletions internal-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import static datadog.trace.api.config.DebuggerConfig.DYNAMIC_INSTRUMENTATION_PR
import static datadog.trace.api.config.DebuggerConfig.DYNAMIC_INSTRUMENTATION_SNAPSHOT_URL
import static datadog.trace.api.config.DebuggerConfig.DYNAMIC_INSTRUMENTATION_UPLOAD_BATCH_SIZE
import static datadog.trace.api.config.DebuggerConfig.DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL
import static datadog.trace.api.config.DebuggerConfig.DYNAMIC_INSTRUMENTATION_UPLOAD_INTERVAL_SECONDS
import static datadog.trace.api.config.DebuggerConfig.DYNAMIC_INSTRUMENTATION_UPLOAD_TIMEOUT
import static datadog.trace.api.config.DebuggerConfig.DYNAMIC_INSTRUMENTATION_VERIFY_BYTECODE
import static datadog.trace.api.config.DebuggerConfig.EXCEPTION_REPLAY_ENABLED
Expand Down Expand Up @@ -256,7 +257,7 @@ class ConfigTest extends DDSpecification {
prop.setProperty(DYNAMIC_INSTRUMENTATION_ENABLED, "true")
prop.setProperty(DYNAMIC_INSTRUMENTATION_PROBE_FILE, "file location")
prop.setProperty(DYNAMIC_INSTRUMENTATION_UPLOAD_TIMEOUT, "10")
prop.setProperty(DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL, "1000")
prop.setProperty(DYNAMIC_INSTRUMENTATION_UPLOAD_INTERVAL_SECONDS, "0.234")
prop.setProperty(DYNAMIC_INSTRUMENTATION_UPLOAD_BATCH_SIZE, "200")
prop.setProperty(DYNAMIC_INSTRUMENTATION_METRICS_ENABLED, "false")
prop.setProperty(DYNAMIC_INSTRUMENTATION_CLASSFILE_DUMP_ENABLED, "true")
Expand Down Expand Up @@ -352,7 +353,7 @@ class ConfigTest extends DDSpecification {
config.getFinalDebuggerSnapshotUrl() == "http://somehost:123/debugger/v1/input"
config.dynamicInstrumentationProbeFile == "file location"
config.dynamicInstrumentationUploadTimeout == 10
config.dynamicInstrumentationUploadFlushInterval == 1000
config.dynamicInstrumentationUploadFlushInterval == 234
config.dynamicInstrumentationUploadBatchSize == 200
config.dynamicInstrumentationMetricsEnabled == false
config.dynamicInstrumentationClassFileDumpEnabled == true
Expand Down