Added the Git integration to segments, and tweaks for the GitHub integration #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
June 17, 2023 17:35
joanreyero
changed the title
sausage-todd
approved these changes
Jun 21, 2023
|
|
||
| const context = await getUserContext(tenantId) | ||
| const segmentRepository = new SegmentRepository(context) | ||
| context.currentSegments = [await segmentRepository.findById(event.segments[0])] |
There was a problem hiding this comment.
Shouldn't we use all segments from event.segments ?
Where is this event.segments coming from? From python worker?
There was a problem hiding this comment.
From the Git integration. Since it's an integration, it will only ever be 1 segment.
There was a problem hiding this comment.
Does it make sense to send only one segment in the first place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 13424bc
This pull request adds segment support to the backend services and repositories, allowing multiple git integrations per platform and segment. It also changes the order of the streams created by the
GithubIntegrationServiceand links the activities to their conversations. It also adds some console logs for debugging purposes.
🤖 Generated by Copilot at 13424bc
Why
How
🤖 Generated by Copilot at 13424bc
memberRepository.ts,sequelizeRepository.ts, link, link)Checklist ✅
Feature,Improvement, orBug.