Skip to content

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Jun 1, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 0e1eeb0

This pull request introduces custom path aliases for the TypeScript code of three services: integration_data_worker, integration_run_worker, and integration_stream_worker. It adds the tsconfig-paths dependency and modifies the package.json and tsconfig.json files of each service to enable path resolution at runtime and compile time. It also renames the config folders to conf in each service to avoid confusion with the config module and updates the import statements accordingly. Additionally, it reorders some import statements alphabetically in the integration_run_worker service.

🤖 Generated by Copilot at 0e1eeb0

Oh we're the workers of the integration code
And we've got a lot of folders to unload
We'll rename them all to conf and use the @/ sign
And we'll heave away with tsconfig-paths on the count of three

Why

How

🤖 Generated by Copilot at 0e1eeb0

  • Add and configure tsconfig-paths dependency to enable custom path aliases in TypeScript configuration files (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Modify start and start:debug scripts to use tsconfig-paths/register module in package.json files of integration_data_worker, integration_run_worker, and integration_stream_worker services (link, link, link)
  • Rename config folder to conf in integration_data_worker, integration_run_worker, and integration_stream_worker services to avoid confusion with config module (link, link, link)
  • Update import statements to reflect the renaming of config folder to conf in main.ts files of integration_data_worker, integration_run_worker, and integration_stream_worker services (link, link, link)
  • Update import statements to use @/ alias for conf folder in integrationDataService.ts, integrationRunService.ts, and integrationStreamService.ts files of integration_data_worker, integration_run_worker, and integration_stream_worker services (link, link, link, link)
  • Modify TypeScript configuration files to enable esModuleInterop option and set baseUrl to ./src and define @/ alias for conf folder in integration_data_worker, integration_run_worker, and integration_stream_worker services (link, link, link)
  • Reorder import statements in integrationRun.data.ts file of integration_run_worker service to follow alphabetical order of imported modules (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt added the Improvement Created by Linear-GitHub Sync label Jun 1, 2023
@themarolt themarolt requested a review from garrrikkotua June 1, 2023 11:07
@themarolt themarolt merged commit 431acee into main Jun 1, 2023
@themarolt themarolt deleted the bugfix/ide-import-autocomplete-fix branch June 1, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants