Skip to content

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented May 18, 2023

Changes proposed ✍️

  • Remove profiles from organizations list, profile and form
  • Fix click on organization's table identities

What

🤖 Generated by Copilot at 5c5ca57

This pull request adds the Facebook integration for the frontend, allowing users to see and link the Facebook profiles of organizations. It also removes some redundant or unused components and attributes related to the organization enrichment and list. It modifies the files integrations-config.js, organization-list-table.vue, organization-identities.vue, organization-enriched.vue, organization-view-aside.vue, buttons.scss, and adds the files facebook/config.js and facebook/index.js. It also removes the profiles attribute from organization-enrichment-attributes.js.

🤖 Generated by Copilot at 5c5ca57

To show Facebook identities
We made some code changes with ease
We added some files
And removed some old styles
And cleaned up the organization keys

Why

How

🤖 Generated by Copilot at 5c5ca57

  • Add &--facebook and &--facebook:hover classes to buttons.scss for styling the Facebook button (link)
  • Add config.js and index.js files to frontend/src/integrations/facebook folder, exporting an object with the image and hideAsIntegration properties for the Facebook integration (link, link)
  • Import and add the Facebook integration to the IntegrationsConfig class in integrations-config.js, which provides the available integrations and their properties (link, link)
  • Display Facebook identity as a platform button with a tooltip and a link in the organization components (link, link, link, link, link, link, link)
    • Add username-handles prop to the app-platform component for the GitHub, LinkedIn, Twitter, and Crunchbase identities in organization-identities.vue, passing the organization's handles as arrays, to show the usernames on the platform button tooltips (link, link, link, link)
    • Add a new app-platform component for the Facebook identity in organization-identities.vue, passing the organization's Facebook handle as an array, the tooltip label, the href, and the as-link props, to display the Facebook button with the profile link and username tooltip (link)
    • Add the props.organization.facebook condition to the showIdentities computed property in organization-identities.vue, to show the identities section if the organization has a Facebook identity (link)
    • Add an else if branch to the getIdentityLink method in organization-identities.vue, to return the URL for the Facebook platform with the handle or the custom URL if available (link)
    • Add a new a element that displays the Facebook identity in organization-view-aside.vue, with the same structure and style as the other platform links, and the href attribute with the Facebook profile URL (link)
    • Add the props.organization.facebook condition to the showIdentities computed property in organization-view-aside.vue, to show the identities section if the organization has a Facebook identity (link)
    • Add the && !props.organization.facebook?.url condition to the showIdentitiesWarning computed property in organization-view-aside.vue, to hide the warning message about the missing identities if the organization has a custom Facebook URL (link)
    • Add an else if branch to the getIdentityLink method in organization-view-aside.vue, to return the URL for the Facebook platform with the handle or the custom URL if available (link)
  • Remove the Profiles column and the profiles attribute from the organization components, as they are redundant with the platform buttons (link, link, link, link, link)
    • Remove the Profiles column from the organization-list-table.vue component, which displayed the profiles of the organizations in a table (link)
    • Remove the import of the AppTags component from the organization-list-table.vue component, which was used to display the profiles as tags (link)
    • Remove the div element that displayed the profiles attribute as tags in the organization-enriched.vue component, which showed the enriched data of the organization in the aside section (link)
    • Remove the import of the AppTags component from the organization-enriched.vue component, which was used to display the profiles as tags (link)
    • Remove the profiles attribute from the organization-enrichment-attributes.js file, which defined the attributes for the organization enrichment (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added Bug Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync labels May 18, 2023
@joanagmaia joanagmaia self-assigned this May 18, 2023
@joanagmaia joanagmaia requested a review from gaspergrom May 18, 2023 15:42
@joanagmaia joanagmaia merged commit a7136fa into main May 22, 2023
@joanagmaia joanagmaia deleted the improvement/display-organizations-profiles branch May 22, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants