Skip to content

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented May 16, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at f2bf24d

This pull request refactors the backend and the serverless functions to use shared libraries in the services directory, and updates the configuration, the CI workflow, and the docker files accordingly. It also adds a new serverless function for the integration run worker, and uses SQS as the message broker. Additionally, it renames the configuration module from config to conf to avoid confusion with the config directory.

🤖 Generated by Copilot at f2bf24d

We're breaking the chains of confusion
We're using the conf module for fusion
We're sending the messages to the queue
We're running the serverless function too

Why

How

🤖 Generated by Copilot at f2bf24d

  • Add CROWD_SQS_INTEGRATION_RUN_WORKER_QUEUE environment variable to enable communication between backend and integration run worker serverless function (link, link, link)
  • Refactor backend and serverless functions to use shared libraries from services directory instead of duplicating code (link, link, link, link, link, link, link, link, link)
  • Simplify and align scripts for linting, formatting and typescript checks in backend/package.json and CI workflow (link, link)
  • Rename configuration module from config to conf to avoid confusion with config directory (link, link, link, link, link, link, link, link, link)
  • Rename docker/docker-compose.test.yaml to backend/docker-compose.test.yaml to reflect its scope (link)
  • Delete unused Dockerfiles for backend and kube (link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt added the Improvement Created by Linear-GitHub Sync label May 25, 2023
@themarolt themarolt marked this pull request as ready for review May 29, 2023 07:31
@themarolt themarolt merged commit ef51a0c into main May 31, 2023
@themarolt themarolt deleted the enhancement/integration-pipeline-optimization-C-1011-C-1265 branch May 31, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant