Skip to content

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented May 9, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 649abac

Improved the UI and logic of webhook automations in the frontend and backend. Changed some labels, filters, and messages to use consistent and clear terminology. Added sorting by updated date for automation records.

🤖 Generated by Copilot at 649abac

We tweaked some UI elements
And fixed some SQL statements
We used lowercase letters
For the Slack messengers
And made the webhooks more consistent

Why

How

🤖 Generated by Copilot at 649abac

  • Change the labels and titles of the dropdown menu items and confirmation dialog for editing and deleting webhook automations to use the term "automation" instead of "webhook" to avoid confusion (link, link, link)
  • Change the condition and value for the filter option and the empty state component for the webhook automation list to use the singular term "webhook" instead of the plural "webhooks" to match the automation type (link, link)
  • Change the text of the Slack message sent after connecting the crowd.dev notifier to use lowercase letters for consistency with the branding in automationSlackCallback.ts (link)
  • Change the SQL query for fetching the automation records from the database to add an order by clause to sort them by the updated date in descending order in automationRepository.ts (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label May 9, 2023
@gaspergrom gaspergrom requested a review from joanagmaia May 9, 2023 13:45
@gaspergrom gaspergrom self-assigned this May 9, 2023
@gaspergrom gaspergrom requested review from epipav and removed request for epipav May 10, 2023 05:57
@gaspergrom gaspergrom merged commit 13b86d9 into main May 10, 2023
@gaspergrom gaspergrom deleted the bugfix/slack-automation branch May 10, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants