Skip to content

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Apr 19, 2023

Changes proposed ✍️

What

  • fixed Deleted User usernames in discord integration service
  • a migration to add weakIdentities column to members database table (empty JSON array by default)
  • updated a script for member de-duplication to handle members that can't be automatically merged by fixing them via weakIdentities column

Why

To prepare the database for member identities changes where each tenant will only be allowed to have one member with a specific platform:username combination (to prevent duplicate members and easier querying).

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Apr 19, 2023
@themarolt themarolt marked this pull request as ready for review April 19, 2023 13:36
@joanreyero joanreyero merged commit 74b8376 into main Apr 19, 2023
@joanreyero joanreyero deleted the enhancement/merge-duplicated-members-with-extra-identities-C-1216 branch April 19, 2023 14:01
@joanreyero joanreyero restored the enhancement/merge-duplicated-members-with-extra-identities-C-1216 branch April 19, 2023 14:01
@themarolt themarolt deleted the enhancement/merge-duplicated-members-with-extra-identities-C-1216 branch April 19, 2023 14:02
joanreyero pushed a commit that referenced this pull request Apr 19, 2023
@joanreyero joanreyero restored the enhancement/merge-duplicated-members-with-extra-identities-C-1216 branch April 19, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants