Skip to content

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Apr 7, 2023

Changes proposed ✍️

  • Move member identities to a dedicated table memberIdentities from their current place in members.username column.
  • Add username column to activities to see which particular member identity added the activity

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

Copy link
Collaborator

@epipav epipav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing review webhooks, please ignore :-) test

@themarolt themarolt changed the base branch from main to feature/merge-duplicated-members-C-1024 April 13, 2023 08:34
Base automatically changed from feature/merge-duplicated-members-C-1024 to main April 13, 2023 14:46
@themarolt themarolt added the Improvement Created by Linear-GitHub Sync label Apr 17, 2023
@themarolt themarolt marked this pull request as ready for review April 17, 2023 09:18
@epipav epipav self-requested a review April 17, 2023 14:08
Copy link
Collaborator

@epipav epipav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test 2

Copy link
Collaborator

@epipav epipav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 included one nitpick

@themarolt themarolt merged commit 237d277 into main Apr 20, 2023
@themarolt themarolt deleted the feature/member-identities-C-1026 branch April 20, 2023 03:29
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants