Skip to content

Fix member manual creation with email only #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2022
Merged

Fix member manual creation with email only #377

merged 1 commit into from
Dec 22, 2022

Conversation

mariobalca
Copy link
Contributor

@mariobalca mariobalca commented Dec 22, 2022 •
edited
Loading

Changes proposed ✍️

  • Set model.platform as email if model.email exists
  • Set model.username.email if model.email exists

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@mariobalca mariobalca added the Bug Created by Linear-GitHub Sync label Dec 22, 2022
@mariobalca mariobalca self-assigned this Dec 22, 2022
joanagmaia
joanagmaia approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariobalca mariobalca merged commit 88a4ccd into main Dec 22, 2022
@mariobalca mariobalca deleted the bugfix/create-member-with-only-email branch December 22, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanagmaia joanagmaia joanagmaia approved these changes

Assignees

@mariobalca mariobalca

Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariobalca @joanagmaia