Skip to content

Conversation

joanagmaia
Copy link
Contributor

Changes proposed ✍️

  • Update Trial badge interaction next to workspace plan
    • Redirect to pricing and plans page when badge is clicked
    • Update background color when badge is hovered

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Dec 19, 2022
@@ -46,7 +46,13 @@
{{ getPlan(currentTenant.plan) }}
<span
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the only action this badge will be performing is router.push, maybe we could use <router-link> instead and drop the import/initialization related to the router

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right, I didn't use it because I thought I couldn't stop the click propagation with it. Just saw that I can the same way, so updated!

Thanks for the suggestion 🙏

Copy link
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tweak! LGTM 💪

@joanagmaia joanagmaia merged commit aa3dffb into main Dec 19, 2022
@joanagmaia joanagmaia deleted the bug/trial-tag-interaction branch December 19, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants