Reddit integration #351
Reddit integration #351
Conversation
…rowd.dev into feature/reddit-integration
…rowd.dev into feature/reddit-integration
There was a problem hiding this comment.
Left some minor comments/questions, but shouldn't be a blocker to merge
One thing that I've noticed is that with Pizzly, we're now doing an integration OAuth within a popup, which is not consistent in terms of UX with the other integrations.
Maybe we should think about refactoring the old ones to have popups as well.
Other than that, everything looks good to me! Nice work 🙌
| import PermissionChecker from '../../../services/user/permissionChecker' | ||
|
|
||
| export default async (req, res) => { | ||
| new PermissionChecker(req).validateHas(Permissions.values.tenantEdit) |
There was a problem hiding this comment.
Shouldn't we be validating the Permissions.values.integrationCreate instead?
There was a problem hiding this comment.
Yes, actually. All integrations are like this, though. I will create an issue to move all.
| result.data.data.children && | ||
| result.data.data.children.length > 0 | ||
| ) { | ||
| track(req, 'Reddit: subreddit input', { |
There was a problem hiding this comment.
Are we sure we want track to these (both the valid and not valid)?
What kind of insights are we hoping to get?
There was a problem hiding this comment.
We would have the option to implement fetching the subreddits that people own. I am hoping this will give us a sense of whether people are struggling with the setup, to see if we should implement that.
Changes proposed ✍️
Added Reddit integration. We are not getting posts and their comments for given subreddits.
Added Pizzly for quick handling of OAuth processes
Screenshots
Checklist ✅
Feature,Enhancement, orBug.frontend/.env.dist.local,frontend/.env.dist.composed.backend/.env.dist.local,backend/.env.dist.composed.