Skip to content

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Dec 12, 2022

Changes proposed ✍️

  • Ensuring index properties on each creates is unnecessary, removed the ensureIndexSettings call on create a document.
  • I'll provide util functions to change these settings in a migration manner, tho this needs to be merged so the task queue can process the already existing tasks in the queue

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@epipav epipav self-assigned this Dec 12, 2022
@epipav epipav added the Bug Created by Linear-GitHub Sync label Dec 12, 2022
@epipav epipav force-pushed the bugfix/meilisearch-too-many-enqueued-tasks branch from ce37ba2 to 7164c73 Compare December 12, 2022 15:26
@epipav epipav marked this pull request as ready for review December 12, 2022 15:39
@epipav epipav requested a review from joanreyero December 12, 2022 15:55
@epipav epipav merged commit cffd492 into main Dec 12, 2022
@epipav epipav deleted the bugfix/meilisearch-too-many-enqueued-tasks branch December 12, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants