fix: sync GitHub disconnection to git integration [CM-675] #3384
Conversation
| @@ -1,6 +1,6 @@ | |||
| # Global settings | |||
| KUBE_MODE=1 | |||
| CROWD_EDITION=community | |||
There was a problem hiding this comment.
This change is out of scope for this PR, but the default should be lfx to avoid inconsistent local/prod behavior
| let insightsProject = null | ||
| if (segmentId) { | ||
| const [project] = await collectionService.findInsightsProjectsBySegmentId(segmentId) | ||
| insightsProject = project | ||
| } | ||
|
|
||
| const { widgets } = await collectionService.findSegmentsWidgetsById(segmentId) | ||
| let widgets = [] | ||
| if (segmentId) { | ||
| const widgetsResult = await collectionService.findSegmentsWidgetsById(segmentId) | ||
| widgets = widgetsResult.widgets | ||
| } | ||
|
|
||
| const insightsRepo = insightsProject?.repositories ?? [] | ||
|
|
||
| await deleteSegmentRepositories(qx, { | ||
| segmentId, | ||
| }) | ||
| if (segmentId) { | ||
| await deleteSegmentRepositories(qx, { | ||
| segmentId, | ||
| }) | ||
| } |
There was a problem hiding this comment.
@ulemons For some reason, this fails locally due to missing segmentId. I didn't investigate further, but the check seems to work. And from a quick test this isn't happening on staging/prod so I assume it has something to do with local setup
There was a problem hiding this comment.
i ll do a quick test in local env. btw do you make sense to do everything inside one if (segmentId) block ? maybe it is easier to read. what do you think ?
There was a problem hiding this comment.
approved, for me is working locally 👍
There was a problem hiding this comment.
Definitely makes sense 👍
It's fixed
Changes proposed ✍️
This pull request updates integration removal logic and environment configuration to better support the LFX Enterprise Edition and improve the handling of Git integrations. The main changes include switching the default edition to
lfx-ee, enhancing the cleanup process for Git integrations, and improving robustness for segment-based operations.Edition and environment configuration:
CROWD_EDITIONin.env.dist.localfromcommunitytolfx-ee, aligning the configuration with LFX Enterprise Edition requirements.Integration removal and Git integration handling:
IntegrationServiceto always use the LFX logic, removing the previous edition check and ensuring consistent behavior.Robustness improvements for segment-based operations:
segmentIdbefore performing operations related to insights projects and widgets, preventing potential errors whensegmentIdis undefined.segmentIdis present, increasing code safety.Checklist ✅
Feature,Improvement, orBug.