Skip to content

Conversation

joanagmaia
Copy link
Contributor

Changes proposed ✍️

  • Added missing label property to model value both in Related members and assignees
  • Refactor fetchMembers so that it can fetch for a limited set of users and users that are selected but are not included on that list
  • Disable inputs and prevent showing empty tags when options are still loading

Relates to #261

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Dec 9, 2022
@joanagmaia joanagmaia requested a review from joanreyero December 9, 2022 12:08
@joanagmaia joanagmaia self-assigned this Dec 9, 2022
Copy link
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joanagmaia joanagmaia merged commit c602510 into main Dec 9, 2022
@joanagmaia joanagmaia deleted the bug/tasks-related-members branch December 9, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants