Skip to content

Conversation

joanagmaia
Copy link
Contributor

Changes proposed ✍️

  • Move loading to bottom of widget header to allow interaction if something fails (e.g delete/edit widget)
  • Remove "[Identities] Count" from measures
  • Add [Sentiment] platform to dimensions when [Sentiment] Average is selected
  • Fix graph colors
  • Fix chart type pre-selection
  • Disable selection components when there is 1 or no options

Relates to #279

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Dec 3, 2022
@joanagmaia joanagmaia self-assigned this Dec 3, 2022
@joanreyero joanreyero self-requested a review December 4, 2022 12:13
Copy link
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks for taking care of it so quickly!

@joanagmaia joanagmaia merged commit 4e2fcbe into main Dec 5, 2022
@joanagmaia joanagmaia deleted the bug/reports-additional-issues branch December 5, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants