Skip to content

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Nov 23, 2022

Changes proposed ✍️

New fields and filters for the organization module:

  • filter by activity count => field name: activityCount
  • filter by member count => field name: memberCount
  • filter by first activity time => field name: joinedAt
  • filter by employee count => field name: employees

New filter for activity module

  • filter by organizationId => filed name: organizations

Example payload:

{
   filter: {
       organizations: [organizationId1, organizationId2]
  }
}

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit bb78d6d
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/6380a08833f3fc000911aace

@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit bb78d6d
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/6380a0870d14ed000918bb04

@epipav epipav self-assigned this Nov 24, 2022
@epipav epipav requested a review from mariobalca November 25, 2022 11:02
@epipav epipav marked this pull request as ready for review November 25, 2022 11:02
Copy link
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Thanks for handling these 🙏

@mariobalca mariobalca merged commit 782883d into main Nov 25, 2022
@mariobalca mariobalca deleted the feature/activities-filter-by-organization branch November 25, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants