Skip to content

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Nov 22, 2022

Changes proposed ✍️

  • Github integration service now passes the next page to processor
  • Fixes an edge case for get organizations from github. When the organization name had backslashes in it, the string was not interpolating correctly resulting in an error. Now we sanitize the name from backslashes before sending it to the api.

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link

netlify bot commented Nov 22, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 035c513
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/637d08310bb13200088f9fff

@netlify
Copy link

netlify bot commented Nov 22, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 035c513
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/637d08310bb13200088fa004

@epipav epipav changed the title gh integration service now sends next page back to processor Github integration paging problem Nov 22, 2022
@epipav epipav self-assigned this Nov 22, 2022
@epipav epipav marked this pull request as ready for review November 22, 2022 17:35
@epipav epipav merged commit c63a1b9 into main Nov 23, 2022
@epipav epipav deleted the bugfix/github-stream-paging branch November 23, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants