Skip to content

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Nov 18, 2022

Changes proposed ✍️

  • Refactor member dropdown component to allow the "Make primary" action
  • Create a watcher for memberToMerge, so that it handles all logic related to its value change. For change member, make primary, and add new member action.
  • Add an handler for the make-primary event emitted from the app-member-suggestions-details component

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia self-assigned this Nov 18, 2022
@netlify
Copy link

netlify bot commented Nov 18, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 853f8be
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/6377a9ba9ae608000817a1b3

@netlify
Copy link

netlify bot commented Nov 18, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 853f8be
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/6377a9ba0ff960000819035c

Copy link
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this one 🙏
Feel free to merge 💪

@joanagmaia joanagmaia merged commit b17b2d7 into main Nov 21, 2022
@joanagmaia joanagmaia deleted the bug/merge-members-make-primary branch November 21, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants