Skip to content

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Nov 11, 2022

Changes proposed ✍️

  • Clear interval for fetching an integration when component is unmounted (this could cause errors when switching tenant)
  • Fix getter name for loading
  • Reset integrations store after the tenant switch is made by calling the buildInitialStore function

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link

netlify bot commented Nov 11, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit cb4fea9
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/636e2c4f2dd79000095f99d9

@netlify
Copy link

netlify bot commented Nov 11, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit cb4fea9
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/636e2c4f3f01a5000805bb4a

@joanagmaia joanagmaia force-pushed the bug/integrations-page branch from 7dc2938 to 0360904 Compare November 11, 2022 11:04
@joanagmaia joanagmaia force-pushed the bug/integrations-page branch from 0360904 to cb4fea9 Compare November 11, 2022 11:04
Copy link
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

Copy link
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling (twice) this!
Will merge 💪

@mariobalca mariobalca merged commit 5feeac2 into main Nov 11, 2022
@mariobalca mariobalca deleted the bug/integrations-page branch November 11, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants