Skip to content

Conversation

joanagmaia
Copy link
Contributor

Changes proposed ✍️

  • In svg.vue update xlink:href to href. xlink:ref is deprecated https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href
  • Remove default fill from svg paths in crowd-icons.svg. This was preventing me from customizing the fill color on hover. I've passed the default. I've passed the default color to use, except for Google icon
  • Add Email/Contact us menu item to Support menu
  • Update Support menu according to Nuno's feedback
  • Update support anchor placements to allow all menu item to be clickable
  • Screenshots (front-end changes only)

      - ...  
    

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link

netlify bot commented Nov 9, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 2d28bfd
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/636b9dd072278300092f72ff

@netlify
Copy link

netlify bot commented Nov 9, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 2d28bfd
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/636b9dd03a1fdf0008a6e954

Copy link
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Will merge ✌️

@mariobalca mariobalca merged commit fb152e4 into main Nov 9, 2022
@mariobalca mariobalca deleted the enhancement/add-email-to-support branch November 9, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants