Skip to content

Conversation

joanagmaia
Copy link
Contributor

Changes proposed ✍️

Issue:
After publishing/unpublishing a conversation, the conversation drawer opens with no details inside - Task

Approach:

  • Remove Drawer logic from community-help-center-table.vuecomponent. Prevent rerender of entire component when rows/conversations are updated after being fetched in the update request.
  • Move Drawer logic to community-help-center-page.vue. In here, the drawer won't be affected by the table update after the most recent fetch of the table rows.

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit d04a55f
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/636a9f1d2acec70009b84221

@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit d04a55f
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/636a9f1d58b1980009381941

Copy link
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Looks good to me 👍
Will merge!

@mariobalca mariobalca merged commit 7e975e2 into main Nov 9, 2022
@mariobalca mariobalca deleted the bug/publish-conversation-drawer branch November 9, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants