Skip to content

Integrations - only update organization website when it exists #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2023
Merged

Integrations - only update organization website when it exists #1798

merged 2 commits into from
Nov 1, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Nov 1, 2023 •
edited by ghost
Loading

Changes proposed ✍️

What

🤖 Generated by Copilot at 0b37e87

Fix a bug in organization.service.ts that erased the website field of an organization. Add a condition to check the cached website field before updating the database.
​

🤖 Generated by Copilot at 0b37e87

updateData checks
cached website not empty
autumn bug is fixed

Why

How

🤖 Generated by Copilot at 0b37e87

  • Fix a bug where the website field of an organization would be erased by empty cached data (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav requested a review from garrrikkotua November 1, 2023 08:59
@epipav epipav self-assigned this Nov 1, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Nov 1, 2023
@epipav epipav marked this pull request as ready for review November 1, 2023 09:02
@epipav epipav merged commit 6156a92 into main Nov 1, 2023
@epipav epipav deleted the bugfix/integrations-unnecessary-website-updates branch November 1, 2023 09:22
sausage-todd pushed a commit that referenced this pull request Nov 9, 2023
@epipav
Integrations - only update organization website when it exists (#1798)
baffbaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@garrrikkotua garrrikkotua garrrikkotua approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@epipav epipav

Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epipav @garrrikkotua