Skip to content

Merging existing tags error when data.tags is not present #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2023
Merged

Merging existing tags error when data.tags is not present #1784

merged 2 commits into from
Oct 30, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Oct 30, 2023 •
edited
Loading

Changes proposed ✍️

What

🤖 Generated by Copilot at e1574f5

Fix a bug in organizationRepository.ts that overwrites organization tags. The change prevents losing existing tags when updating an organization's profile.
​

🤖 Generated by Copilot at e1574f5

tags undefined?
Use empty array instead
Preserve old values

Why

How

🤖 Generated by Copilot at e1574f5

  • Fix bug of overwriting organization tags when updating profile (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav requested a review from garrrikkotua October 30, 2023 09:12
@epipav epipav self-assigned this Oct 30, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Oct 30, 2023
@epipav epipav marked this pull request as ready for review October 30, 2023 09:12
@epipav epipav merged commit 917efd3 into main Oct 30, 2023
@epipav epipav deleted the bugfix/merging-existing-tags-not-iterable-error branch October 30, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@garrrikkotua garrrikkotua garrrikkotua approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@epipav epipav

Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epipav @garrrikkotua