Skip to content

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Oct 18, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 76f44bd

This pull request adds feature flag and plan limit checks for enabling automation workflows, and refactors the code for creating a new automation. It modifies the automation-toggle.vue and automation-list-page.vue files in the frontend module.

🤖 Generated by Copilot at 76f44bd

AppSwitch controls the fate of automation
Feature flag and limit check your salvation
Simplify the logic, remove the dead code
automation-toggle is the master of the mode

Why

How

🤖 Generated by Copilot at 76f44bd

  • Add a before-change prop to the AppSwitch component to check the feature flag and the workflow limit for automations (link,link)
  • Import modules for the before-change function, including FeatureFlag, getWorkflowMax, showWorkflowLimitDialog, and mapGetters (link)
  • Use the before-change prop in the handleChange function and the currentTenant getter in the automation-toggle.vue file (link)
  • Remove unused imports, functions, and calls related to the feature flag and the workflow limit from the automation-list-page.vue file (link,link,link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Improvement Created by Linear-GitHub Sync label Oct 18, 2023
@joanagmaia joanagmaia requested a review from gaspergrom October 18, 2023 17:16
@joanagmaia joanagmaia self-assigned this Oct 18, 2023
@joanagmaia joanagmaia merged commit bb7ea1f into main Oct 20, 2023
@joanagmaia joanagmaia deleted the improvement/update-automations-limitation branch October 20, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants