Skip to content

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Oct 16, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 86ccbf9

The pull request enhances the organization merging feature by using a new library and a new field to compare organization names by edit distance. It modifies the backend/package.json, backend/src/database/repositories/organizationRepository.ts, and services/apps/search_sync_worker/src/repo/organization.repo.ts files to implement the new logic and synchronize the data between the databases.

🤖 Generated by Copilot at 86ccbf9

fast-levenshtein
merges orgs by name and id
autumn leaves falling

Why

How

🤖 Generated by Copilot at 86ccbf9

  • Replace the opensearch score with the edit distance for measuring the similarity of organizations based on their identities (link, link, link)
  • Add the fast-levenshtein dependency and import it in organizationRepository.ts to compute the edit distance between organization names (link, link)
  • Modify the opensearch query and the interfaces for finding and merging similar organizations to include the nested identities and weak identities of the organizations (link, link, link)
  • Add the weak identities field to the SQL query for fetching organization data in the search_sync_worker service (link)
  • Sort the dependencies in package.json alphabetically for readability and consistency (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav self-assigned this Oct 16, 2023
@epipav epipav added the Improvement Created by Linear-GitHub Sync label Oct 16, 2023
@epipav epipav marked this pull request as ready for review October 16, 2023 07:34
@epipav epipav requested a review from themarolt October 16, 2023 07:43
@epipav epipav merged commit 5e82450 into main Oct 16, 2023
@epipav epipav deleted the improvement/post-process-edit-distances-for-better-scoring branch October 16, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants