Skip to content

Check email domain is not undefined when assigning orgs #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2023
Merged

Check email domain is not undefined when assigning orgs #1637

merged 1 commit into from
Oct 6, 2023

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 6, 2023 •
edited by ghost
Loading

Changes proposed ✍️

What

🤖 Generated by Copilot at 43876a2

Fixed a bug in member.service.ts that could cause an error when processing invalid emails. Improved the email domain analysis logic for the data sink worker service.
​

🤖 Generated by Copilot at 43876a2

isDomainExcluded
Check before calling, avoid
Error in winter

Why

How

🤖 Generated by Copilot at 43876a2

  • Fix potential error when email is invalid or does not contain a domain (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit 1de48a1 into main Oct 6, 2023
@garrrikkotua garrrikkotua deleted the fix/check-domain-is-not-undefined branch October 6, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@garrrikkotua