Skip to content

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Nov 1, 2022

Changes proposed ✍️

  • fixes envs in local development for cube url
  • after moving to api v1, we no longer need to explicitly call the get({plain: true}) on activities, because ConversationRepository.findById function is now returning plain objects instead of sequelize models for activities.
  • Also updated sendgrid email template to reflect the changes. Now it gets body from lastActivity.body instead of obsolete lastActivity.crowdInfo.body

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link

netlify bot commented Nov 1, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit ca617ab
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/63617b1c177759000a33e7de

@netlify
Copy link

netlify bot commented Nov 1, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit ca617ab
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/63617b1c73efc20009394ed7

Copy link
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@epipav epipav merged commit 26276ef into main Nov 4, 2022
@epipav epipav deleted the bugfix/emails-redundant-lastActivity-plain branch November 4, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants