Skip to content

Fix Discord 404s #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Fix Discord 404s #1475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89197b0
handle discord 404 errors
garrrikkotua Sep 12, 2023
8e72a5f
skip 404
garrrikkotua Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions services/libs/integrations/src/integrations/discord/api/getMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export const getMessage = async (
} catch (err) {
if (
err.response &&
err.response.status === 404 &&
err.response.data &&
err.response.data.message === 'Unknown Channel' &&
err.response.data.code === 10003
Expand All @@ -31,6 +32,24 @@ export const getMessage = async (
'Discord API returned Unknown Channel error when fetching message during webhook processing, skipping message.',
)
return null
} else if (
err.response &&
err.response.status === 404 &&
err.response.data &&
err.response.data.message === 'Unknown Message' &&
err.response.data.code === 10008
) {
ctx.log.warn(
{ channelId, messageId },
'Discord API returned Unknown Message error when fetching message during webhook processing, skipping message.',
)
return null
} else if (err.response && err.response.status === 404) {
ctx.log.warn(
{ channelId, messageId },
'Discord API returned 404 error when fetching message during webhook processing, skipping message.',
)
return null
} else {
const newErr = handleDiscordError(err, config, { channelId, messageId }, ctx)
throw newErr
Expand Down