Skip to content

Add tooltip to improve negative filters ux #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Add tooltip to improve negative filters ux #1437

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b237c5
Add tooltip to improve negative filters ux
peoray Sep 6, 2023
c3f7c88
Update styles for FilterIncludeSwitch.vue file
peoray Sep 6, 2023
b1cc74a
Merge branch 'main' into negative-filters-ux
peoray Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/assets/scss/form/switch.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
--el-switch-off-color: #d1d5db; // Gray-300
}

@apply flex grow justify-between items-center ml-4 cursor-pointer;
@apply flex grow-0 justify-between items-center ml-4 cursor-pointer;

// Label
& .el-switch__label {
@apply text-xs text-gray-900 font-medium #{!important};
@apply text-xs text-gray-900 mr-2 font-medium #{!important};
}
}
9 changes: 8 additions & 1 deletion frontend/src/shared/modules/filters/components/partials/FilterIncludeSwitch.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
<template>
<div class="flex justify-start border-b border-gray-100 p-4">
<div class="flex justify-start items-center border-b border-gray-100 p-4">
<el-switch
v-model="model"
:active-text="modelValue ? 'Include' : 'Exclude'"
class="w-fit flex !justify-start !m-0 filter-include-switch"
size="small"
data-qa="filter-include-switch"
/>

<el-tooltip
content="If excluded, turns the filter into a negative condition"
placement="top"
>
<i class="ri-question-line text-gray-400" />
</el-tooltip>
</div>
</template>

Expand Down